Add functions to narrow a TransactionWithLifetime to a specific lifetime#925
Merged
Conversation
🦋 Changeset detectedLatest commit: 5e14804 The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
BundleMonFiles updated (4)
Unchanged files (126)
Total files change +699B +0.19% Final result: ✅ View report in BundleMon website ➡️ |
mcintyre94
force-pushed
the
transaction-lifetime-narrow
branch
3 times, most recently
from
d519278 to
0711961
Compare
Contributor
|
Documentation Preview: https://kit-docs-6o3lsf30u-anza-tech.vercel.app |
steveluscher
approved these changes
Oct 1, 2025
mcintyre94
changed the base branch from
wallet-hook-lifetime
to
graphite-base/925
mcintyre94
force-pushed
the
graphite-base/925
branch
from
28ae2b1 to
8a6cc93
Compare
mcintyre94
force-pushed
the
transaction-lifetime-narrow
branch
from
0711961 to
5e33099
Compare
mcintyre94
changed the base branch from
graphite-base/925
to
wallet-hook-lifetime
mcintyre94
force-pushed
the
transaction-lifetime-narrow
branch
from
5e33099 to
f5dc0b9
Compare
mcintyre94
force-pushed
the
wallet-hook-lifetime
branch
from
8a6cc93 to
3536388
Compare
mcintyre94
force-pushed
the
transaction-lifetime-narrow
branch
from
f5dc0b9 to
52c3c6f
Compare
Member
Author
Merge activity
|
mcintyre94
changed the base branch from
wallet-hook-lifetime
to
graphite-base/925
mcintyre94
force-pushed
the
transaction-lifetime-narrow
branch
from
52c3c6f to
5e14804
Compare
This was referenced Oct 3, 2025
Merged
Closed
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds functions to narrow from a
Transaction | (Transaction & TransactionWithLifetime)toTransactionWithBlockhashLifetimeorTransactionWithDurableNonceLifetime.These functions will be useful when we update the modifying signer API to return
TransactionWithLifetimeinstead of mirroring the input transaction message type. It will then be necessary to use one of these functions to narrow the type if you wish to use Kit's confirmation logic, which depends on a specificlifetimeConstraintbeing attached to transactions.