Export all of the channel creators from @solana/rpc-subscriptions#904
Merged
steveluscher merged 1 commit intoSep 24, 2025
Conversation
🦋 Changeset detectedLatest commit: 46ce855 The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Is this sensible? |
BundleMonFiles updated (1)
Unchanged files (129)
Total files change +59B +0.02% Final result: ✅ View report in BundleMon website ➡️ |
Contributor
|
Documentation Preview: https://kit-docs-1sbhf1h5l-anza-tech.vercel.app |
lorisleiva
approved these changes
Sep 24, 2025
Member
lorisleiva
left a comment
lorisleiva
left a comment
There was a problem hiding this comment.
I think that's a good move. Otherwise we're forcing consumers to re-invent the wheel when all they need to do is tweak the default channel.
mcintyre94
approved these changes
Sep 24, 2025
Member
mcintyre94
left a comment
mcintyre94
left a comment
There was a problem hiding this comment.
Agree with this - it matches how we always intended Kit to be able to be used
steveluscher
deleted the
09-24-export_all_of_the_channel_creators_from_solana_rpc-subscriptions_
branch
Contributor
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Solana Kit Docs' |
This was referenced Sep 16, 2025
Merged
Closed
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In trezor/trezor-suite#19354 I suggested that the maintainers fork the default channel creator so that they can omit the autopinger. It appears as though that isn't even possible, because we don't export everything from
@solana/rpc-subscriptions.Essentially all of this stuff:
kit/packages/rpc-subscriptions/src/rpc-subscriptions-channel.ts
Lines 5 to 9 in 46ce855
Summary of Changes
Exported all of the raw material that one would need to fork
createDefaultSolanaRpcSubscriptionsChannelCreator().