Allow Origin header to be set (for non-browser platforms).#888
Merged
steveluscher merged 4 commits intoSep 16, 2025
Conversation
🦋 Changeset detectedLatest commit: 695dc5c The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
steveluscher
suggested changes
Sep 15, 2025
Contributor
There was a problem hiding this comment.
Take a look at what we did with Accept-Encoding to make it a runtime error when supplied in a non-Node context. Could you do something similar when Origin is supplied in a non-React-Native context? Should we actually allow Origin in all non-browser contexts, but make it a runtime error in browser contexts?
Contributor
Author
|
@steveluscher thanks for the review! IMO it feels reasonable to allow this header across the board: browsers will just ignore it anyways + the use case I cite here could apply to any non-browser environment? But won't die on this hill, happy to make the change if you'd like. |
Contributor
The goal of the type system is to alert the developer of invalid inputs before they run their software, and the goal of runtime invariants is to alert them of invalid inputs the moment the call is made. Now type enforcement is not possible here just for browser builds, since TypeScript doesn't have the concept of ‘use these types for browser builds only,’ but if we take away the runtime enforcement then that will leave the developer on a treasure hunt for why their |
Contributor
Author
|
@steveluscher made the change - lmk if it looks good. will leave it to you to decide in the future whether this should be an error in Node envs, this change should unblock React Native users. |
BundleMonUnchanged files (130)
Total files change +3B 0% Final result: ✅ View report in BundleMon website ➡️ |
Contributor
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Solana Kit Docs' |
This was referenced Sep 16, 2025
Merged
Closed
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As described in the ticket, React Native clients do not automatically set an Origin header. This is preventing us from using Triton's SWQOS since it restricts access by Origin header.
Summary of Changes
Remove Origin from list of forbidden headers.
Fixes #887