Do not allow decoding transactions with an unsupported version#871
Merged
Conversation
🦋 Changeset detectedLatest commit: 6e00621 The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
BundleMonFiles updated (7)
Unchanged files (123)
Total files change +590B +0.16% Final result: ✅ View report in BundleMon website ➡️ |
mcintyre94
commented
Sep 10, 2025
Comment on lines
+39
to
+43
| if (value > MAX_SUPPORTED_TRANSACTION_VERSION) { | ||
| throw new SolanaError(SOLANA_ERROR__TRANSACTION__VERSION_NUMBER_NOT_SUPPORTED, { | ||
| unsupportedVersion: value, | ||
| }); | ||
| } |
Member
Author
There was a problem hiding this comment.
I've also disallowed encoding a TransactionVersion > 0, but I haven't added other checks for encoding because I don't think there's risk of accidentally encoding the wrong versions from Kit APIs, and we have a Typescript type for valid versions.
I mostly did this because I don't think it makes sense to have different supported/unsupported versions in the encode and decode tests.
Contributor
|
Documentation Preview: https://kit-docs-2vu8exd9a-anza-tech.vercel.app |
mcintyre94
force-pushed
the
tx-version-unsupported
branch
from
69c5e04 to
ab69e7c
Compare
steveluscher
approved these changes
Sep 11, 2025
| [SOLANA_ERROR__TRANSACTION__VERSION_NUMBER_OUT_OF_RANGE]: | ||
| 'Transaction version must be in the range [0, 127]. `$actualVersion` given', | ||
| [SOLANA_ERROR__TRANSACTION__VERSION_NUMBER_NOT_SUPPORTED]: | ||
| 'This version of Kit does not support decoding transactions with version $unsupportedVersion. The current max supported version is 0.', |
Contributor
There was a problem hiding this comment.
I like this better than what I wrote in the offchain messages PR. I'm going to use this instead.
Comment on lines
+243
to
+251
| if ( | ||
| compiledTransactionMessage.version !== 'legacy' && | ||
| compiledTransactionMessage.version > MAX_SUPPORTED_TRANSACTION_VERSION | ||
| ) { | ||
| throw new SolanaError(SOLANA_ERROR__TRANSACTION__VERSION_NUMBER_NOT_SUPPORTED, { | ||
| actualVersion: compiledTransactionMessage.version, | ||
| }); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Does this need to be here? If we:
- Hardcode
0into theVersionedCompiledTransactionMessagetype. - Can't decode v1 transactions with the codec after this PR.
…then you should never be able to obtain one of these data structures, right?
Member
Author
There was a problem hiding this comment.
I think you're right, updated. The test I added for this is now a type error (version: 1) so I removed that test. But I think this is cleaner and it makes more sense to restrict the type there.
mcintyre94
force-pushed
the
tx-version-unsupported
branch
from
ab69e7c to
154a047
Compare
mcintyre94
force-pushed
the
tx-version-unsupported
branch
from
154a047 to
defcbe9
Compare
mcintyre94
force-pushed
the
tx-version-unsupported
branch
from
defcbe9 to
6e00621
Compare
This was referenced Sep 30, 2025
Merged
Closed
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Kit currently supports codecs for legacy transactions, and transactions with version 0. There's currently a SIMD for transactions with version 1, which drastically changes how transactions are encoded. Kit will currently decode transactions claiming to have transaction message 1, but this decoding will be nonsense when such transactions exist.
Summary of Changes
We now throw a SolanaError when we decode a transaction and receive a version number greater than 0.
A future version of Kit will be able to add support for v1 transactions, while continuing to throw for still unsupported versions.
Fixes #866