Correct the type of the polyfilled exportKey and sign methods#806
Merged
steveluscher merged 1 commit intoSep 2, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 7e29bd6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
BundleMonFiles updated (3)
Unchanged files (127)
Total files change +97B +0.03% Final result: ✅ View report in BundleMon website ➡️ |
steveluscher
force-pushed
the
08-29-correct_the_type_of_the_polyfilled_exportkey_and_sign_methods
branch
from
7fd15a9 to
43f571d
Compare
Contributor
Author
|
I deemed this not a breaking change, since the API was already typed |
steveluscher
commented
Aug 29, 2025
Comment on lines
+171
to
+173
| const result = new Uint8Array(ED25519_PKCS8_HEADER.length + secretKeyBytes.length); | ||
| result.set(ED25519_PKCS8_HEADER, 0); | ||
| result.set(secretKeyBytes, ED25519_PKCS8_HEADER.length); |
Contributor
Author
There was a problem hiding this comment.
More efficient way of building this that doesn't involve constructing two arrays.
steveluscher
force-pushed
the
08-29-correct_the_type_of_the_polyfilled_exportkey_and_sign_methods
branch
from
43f571d to
e43f311
Compare
steveluscher
force-pushed
the
08-29-a_jest_matcher_that_lets_you_write_expectations_about_the_equality_of_arraybuffers_
branch
from
75753c2 to
430391b
Compare
steveluscher
force-pushed
the
08-29-correct_the_type_of_the_polyfilled_exportkey_and_sign_methods
branch
from
6091483 to
e43f311
Compare
Contributor
|
Documentation Preview: https://kit-docs-ipt84ql0a-anza-tech.vercel.app |
lorisleiva
approved these changes
Sep 1, 2025
Contributor
Author
Merge activity
|
steveluscher
changed the base branch from
08-29-a_jest_matcher_that_lets_you_write_expectations_about_the_equality_of_arraybuffers_
to
graphite-base/806
steveluscher
force-pushed
the
08-29-correct_the_type_of_the_polyfilled_exportkey_and_sign_methods
branch
from
e43f311 to
7e29bd6
Compare
steveluscher
deleted the
08-29-correct_the_type_of_the_polyfilled_exportkey_and_sign_methods
branch
This was referenced Sep 2, 2025
Merged
Contributor
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Solana Kit Docs' |
Closed
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The return type of
exportKeyandsignisArrayBufferbut we're returningUint8Array. This wasn't caught until an upgrade to TypeScript 5.9 where this became a type error.Summary of Changes
Return
ArrayBufferinstead.