The recent transaction confirmation strategy now throws transaction errors from the one-shot test#793
Merged
Conversation
🦋 Changeset detectedLatest commit: 5af0d79 The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
BundleMonFiles updated (3)
Unchanged files (127)
Total files change +46B +0.01% Final result: ✅ View report in BundleMon website ➡️ |
…rrors from the one-shot test
steveluscher
force-pushed
the
08-28-the_recent_transaction_confirmation_strategy_now_throws_transaction_errors_from_the_one-shot_test
branch
from
876d2ad to
5af0d79
Compare
Contributor
|
Documentation Preview: https://kit-docs-14fhf3mmj-anza-tech.vercel.app |
steveluscher
deleted the
08-28-the_recent_transaction_confirmation_strategy_now_throws_transaction_errors_from_the_one-shot_test
branch
Contributor
Author
Merge activity
|
This was referenced Aug 29, 2025
Merged
steveluscher
added
the
backport backport/v3.x
Graphite App
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 29, 2025
…rrors from the one-shot test (#793) #### Problem The recent signature transaction strategy does two things: - Subscribes for changes to a signature's status - Does a point lookup of the signature's status It was reported that if the signature's status is an error, the one-shot lookup would not throw it. #### Summary of Changes Throw any transaction errors discovered during the one-shot lookup. Fixes #711. (cherry picked from commit cfc1d92)
steveluscher
added a commit
that referenced
this pull request
Aug 29, 2025
…rrors from the one-shot test (#793) (#803) #### Problem The recent signature transaction strategy does two things: - Subscribes for changes to a signature's status - Does a point lookup of the signature's status It was reported that if the signature's status is an error, the one-shot lookup would not throw it. #### Summary of Changes Throw any transaction errors discovered during the one-shot lookup. Fixes #711. (cherry picked from commit cfc1d92) Co-authored-by: Steven Luscher <steveluscher@users.noreply.github.com>
This was referenced Sep 1, 2025
Closed
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The recent signature transaction strategy does two things:
It was reported that if the signature's status is an error, the one-shot lookup would not throw it.
Summary of Changes
Throw any transaction errors discovered during the one-shot lookup.
Fixes #711.