Deprecate invocations of isProgramError that rely on the user supplying a transaction message to decode the error#513
Conversation
🦋 Changeset detectedLatest commit: 39662f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
BundleMonFiles updated (7)
Unchanged files (120)
Total files change +822B +0.23% Final result: ✅ View report in BundleMon website ➡️ |
Contributor
|
Documentation Preview: https://kit-docs-24elr27gv-anza-tech.vercel.app |
steveluscher
force-pushed
the
05-30-instruction_errors_now_carry_the_address_and_inner_index_of_the_program_responsible_for_the_error
branch
from
ab226d4 to
63a1461
Compare
steveluscher
force-pushed
the
05-30-deprecate_invocations_of_isprogramerror_that_rely_on_the_user_supplying_a_transaction_message_to_decode_the_error
branch
2 times, most recently
from
4a22f52 to
3f1fc8d
Compare
steveluscher
force-pushed
the
05-30-instruction_errors_now_carry_the_address_and_inner_index_of_the_program_responsible_for_the_error
branch
from
63a1461 to
9fe7733
Compare
…ying a transaction message to decode the error
steveluscher
force-pushed
the
05-30-deprecate_invocations_of_isprogramerror_that_rely_on_the_user_supplying_a_transaction_message_to_decode_the_error
branch
from
3f1fc8d to
39662f2
Compare
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
isProgramErrorused to return unreliable results in cases where the error actually originated from a cross-program invocation (CPI). Now that the validator supplies the actual responsible program address in error responses, we can fix this.Summary of Changes
Deprecated the old call signature of
isProgramErrorand taught it to use the newresponsibleProgramAddressproperty ofSolanaErrordirectly.Depends on anza-xyz/agave#6083
Fixes #149