Add NO_SIGNER_CONNECTED and SIGNER_NOT_AVAILABLE wallet errors#1542
Merged
Conversation
🦋 Changeset detectedLatest commit: f55bf35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 46 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
BundleMonFiles updated (7)
Unchanged files (137)
Total files change +332B +0.07% Final result: ✅ View report in BundleMon website ➡️ |
mcintyre94
force-pushed
the
new-wallet-errors
branch
from
ddbb18d to
45d409c
Compare
Contributor
|
Documentation Preview: https://kit-docs-ofiahsrcf-anza-tech.vercel.app |
mcintyre94
force-pushed
the
new-wallet-errors
branch
from
45d409c to
f55bf35
Compare
Contributor
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Solana Kit Docs' |
This was referenced Apr 16, 2026
Merged
Closed
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
These are new errors that will be thrown when accessing
client.identityorclient.payerwhile those are controlled by a wallet plugin and there is not a signer for a connected wallet available.There are 2 cases:
SOLANA_ERROR__WALLET__NO_SIGNER_CONNECTEDwill be used when no wallet is connected. It includes astatus, which in the wallet plugin will be one of its statuses, such asdisconnectedorpending. In the error definition it's just a string though.SOLANA_ERROR__WALLET__SIGNER_NOT_AVAILABLEwill be used when a wallet is connected, but a signer was not created for it because of missing features. In this case asclient.identityandclient.payerare both signer fields, we cannot set them and will throw this error.Note that the first is differentiated from
SOLANA_ERROR__WALLET__NOT_CONNECTEDbecause we're trying to access a field controlled by the wallet, not perform an operation on the wallet. Its messageCannot $operation: no wallet connecteddoesn't work, and its context does not includestatus.Also note that these don't specify the field that is being accessed, I think the stacktrace will provide that and it makes these error codes more reusable and less tied to precisely how plugins use them.