Fix a bug where a message packer that requires multiple iterations is not correctly added to a transaction#1256
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 282b517 The changes in this PR will be included in the next version bump. This PR includes changesets to release 43 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
BundleMonUnchanged files (136)
Total files change -7B 0% Final result: ✅ View report in BundleMon website ➡️ |
Contributor
|
Documentation Preview: https://kit-docs-r4toc8ya7-anza-tech.vercel.app |
lorisleiva
approved these changes
Jan 27, 2026
Member
lorisleiva
left a comment
lorisleiva
left a comment
There was a problem hiding this comment.
🤦♂️ Sorry for this pretty critical typo. Thank you Claude for discovering it and Callum for implementing it with a very thorough test! 🙏
Contributor
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Solana Kit Docs' |
Merged
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the case where
fitEntirePlanInsideMessageis used on aMessagePackerInstructionPlan, we iterate over the message packer until it is done (or throws). But these iterations were not being accumulated correctly, and only the last iteration would actually be applied.This is an edge case, because a well implemented message packer will fill the transaction in only one call, and usually they're not forced into a single transaction.
Summary of Changes
packMessageToCapacitypackMessageToCapacityis called.Aside: spotted this because an AI tab complete model suggested changing it, and was correct for once!