Remove typescript peerDependency from all packages#1188
Closed
friederbluemle wants to merge 1 commit into
Closed
Conversation
|
BundleMonUnchanged files (136)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
Co-authored-by: Callum McIntyre <callum.mcintyre@anza.xyz>
friederbluemle
force-pushed
the
rm-ts-peer
branch
from
9250e7d to
e4351c3
Compare
Author
|
Thanks @mcintyre94 for updating the lockfile (sorry I initially missed it)! I squashed the two commits (it should be one atomic changeset), and added |
Member
|
Closing in favour of #1187, but thankyou again! :) |
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
See #1161 for full context.
Summary
typescriptpeerDependency from 42 packagesdist/, so consumers don't need TypeScript to use them.d.ts) work regardless of consumer's TypeScript versionContext
The TypeScript peerDependency was causing excessive warnings for consumers, especially those using
@solana/kitas a transitive dependency. Since the packages are published as a "Solana JavaScript SDK" with compiled output, there's no strict requirement for consumers to have any specific TypeScript version (or TypeScript at all).Fixes #1161
Replaces #1187