feat: Add local rent exemption calculator#1065
Merged
mcintyre94 merged 2 commits intoJan 7, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 8fa6ff0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 43 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
steveluscher
force-pushed
the
feature/rent-exemption-helper
branch
from
f6a6044 to
4bc9a37
Compare
BundleMonFiles updated (4)
Unchanged files (132)
Total files change +704B +0.18% Final result: ✅ View report in BundleMon website ➡️ |
mcintyre94
requested changes
Dec 16, 2025
Member
mcintyre94
left a comment
mcintyre94
left a comment
There was a problem hiding this comment.
Thanks for this! The logic looks good, just a small nitpick on the function signature.
| * | ||
| * @param space The number of bytes of account data. | ||
| */ | ||
| export function getMinimumBalanceForRentExemption(space: bigint | number = 0): Lamports { |
Member
There was a problem hiding this comment.
I'd prefer to just use bigint as input here, to match the rest of the library. We generally leave type conversion to callers to make the library simpler and avoid branching (in cases where that's relevant).
I'd also remove the default, because I think it'll make the calling code clearer.
Member
|
Re the CI issue, if you run Re the changeset, as this is new functionality we'd want to release a new version with this. If you do |
rajgoesout
force-pushed
the
feature/rent-exemption-helper
branch
3 times, most recently
from
887d405 to
657cb0f
Compare
Contributor
Author
|
@mcintyre94 Thank you for the review. I've updated the function signature, fixed prettier issues, and included the changeset. |
mcintyre94
reviewed
Dec 16, 2025
rajgoesout
force-pushed
the
feature/rent-exemption-helper
branch
from
657cb0f to
153bc9c
Compare
mcintyre94
force-pushed
the
feature/rent-exemption-helper
branch
from
153bc9c to
ca916a5
Compare
mcintyre94
force-pushed
the
feature/rent-exemption-helper
branch
from
8aa358b to
9a831c7
Compare
github-actions
Bot
dismissed
mcintyre94’s stale review
Your organization requires reapproval when changes are made, so Graphite has dismissed approvals. See the output of git range-diff at https://github.com/anza-xyz/kit/actions/runs/20787741799
mcintyre94
force-pushed
the
feature/rent-exemption-helper
branch
from
9a831c7 to
914ae56
Compare
mcintyre94
previously approved these changes
Jan 7, 2026
mcintyre94
force-pushed
the
feature/rent-exemption-helper
branch
from
914ae56 to
8fa6ff0
Compare
github-actions
Bot
dismissed
mcintyre94’s stale review
Your organization requires reapproval when changes are made, so Graphite has dismissed approvals. See the output of git range-diff at https://github.com/anza-xyz/kit/actions/runs/20789825575
mcintyre94
approved these changes
Jan 7, 2026
Member
mcintyre94
left a comment
mcintyre94
left a comment
There was a problem hiding this comment.
Thankyou for this! And thankyou for your patience getting it merged!
Member
Contributor
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Solana Kit Docs' |
Merged
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Logic for the getMinimumBalanceForRentExemption function is stateless, so there's no need to make an rpc call.
Summary of Changes
packages/kit/src/get-minimum-balance-for-rent-exemption.tspackages/kit/src/index.ts.Tests added
packages/kit/src/__tests__/get-minimum-balance-for-rent-exemption-test.tsCloses #777