Skip to content

blockstore: Remove slow test_purge_huge#9087

Merged
steviez merged 1 commit intoanza-xyz:masterfrom
steviez:bstore_rm_slow_test
Nov 15, 2025
Merged

blockstore: Remove slow test_purge_huge#9087
steviez merged 1 commit intoanza-xyz:masterfrom
steviez:bstore_rm_slow_test

Conversation

@steviez
Copy link
Copy Markdown

@steviez steviez commented Nov 14, 2025

Problem

image

test_purge_huge is a slow test. We have the same correctness coverage with below test:

#[test]
fn test_purge_slots() {
let ledger_path = get_tmp_ledger_path_auto_delete!();
let blockstore = Blockstore::open(ledger_path.path()).unwrap();
let (shreds, _) = make_many_slot_entries(0, 50, 5);
blockstore.insert_shreds(shreds, None, false).unwrap();
blockstore.purge_and_compact_slots(0, 5);
test_all_empty_or_min(&blockstore, 6);
blockstore.purge_and_compact_slots(0, 50);
// min slot shouldn't matter, blockstore should be empty
test_all_empty_or_min(&blockstore, 100);
test_all_empty_or_min(&blockstore, 0);
blockstore
.slot_meta_iterator(0)
.unwrap()
.for_each(|(_, _)| {
panic!();
});
}

So, the only "value" remaining for this test is as a "bench". CI isn't the right place for that as the results will be noisy from all the tests running in parallel. Additionally, we significantly optimized purge a while back (solana-labs#26651); it'd hypothetically be nice to have a guard to ensure we don't make it worse again but this CI test isn't that so this isn't a reason to hang onto the test either

Solution

Rip the test and give everyone their 2-3 minutes / CI run back

We have similar correctness coverage with another test so we don't get
much from this test inserting 1000's of slots
@steviez steviez force-pushed the bstore_rm_slow_test branch from 59bee3b to b714bac Compare November 14, 2025 23:58
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.6%. Comparing base (44d181a) to head (b714bac).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #9087     +/-   ##
=========================================
- Coverage    82.6%    82.6%   -0.1%     
=========================================
  Files         888      888             
  Lines      320595   320595             
=========================================
- Hits       265105   265073     -32     
- Misses      55490    55522     +32     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@steviez steviez requested review from a team and cpubot November 15, 2025 00:45
Copy link
Copy Markdown

@cpubot cpubot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪦

Copy link
Copy Markdown
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@steviez steviez marked this pull request as ready for review November 15, 2025 03:42
@steviez steviez added this pull request to the merge queue Nov 15, 2025
Merged via the queue into anza-xyz:master with commit 360411c Nov 15, 2025
46 checks passed
@steviez steviez deleted the bstore_rm_slow_test branch November 15, 2025 03:47
rustopian pushed a commit to rustopian/agave that referenced this pull request Nov 20, 2025
We have similar correctness coverage with another test so we don't get
much from this test inserting 1000's of slots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants