blockstore: Remove slow test_purge_huge#9087
Merged
steviez merged 1 commit intoanza-xyz:masterfrom Nov 15, 2025
Merged
Conversation
We have similar correctness coverage with another test so we don't get much from this test inserting 1000's of slots
59bee3b to
b714bac
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9087 +/- ##
=========================================
- Coverage 82.6% 82.6% -0.1%
=========================================
Files 888 888
Lines 320595 320595
=========================================
- Hits 265105 265073 -32
- Misses 55490 55522 +32 🚀 New features to boost your workflow:
|
rustopian
pushed a commit
to rustopian/agave
that referenced
this pull request
Nov 20, 2025
We have similar correctness coverage with another test so we don't get much from this test inserting 1000's of slots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_purge_hugeis a slow test. We have the same correctness coverage with below test:agave/ledger/src/blockstore/blockstore_purge.rs
Lines 527 to 551 in bf93218
So, the only "value" remaining for this test is as a "bench". CI isn't the right place for that as the results will be noisy from all the tests running in parallel. Additionally, we significantly optimized purge a while back (solana-labs#26651); it'd hypothetically be nice to have a guard to ensure we don't make it worse again but this CI test isn't that so this isn't a reason to hang onto the test either
Solution
Rip the test and give everyone their 2-3 minutes / CI run back