vendor quinn#8281
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8281 +/- ##
=======================================
Coverage 83.2% 83.2%
=======================================
Files 836 836
Lines 366679 366679
=======================================
+ Hits 305266 305279 +13
+ Misses 61413 61400 -13 🚀 New features to boost your workflow:
|
| version = "0.5.12" | ||
| source = "git+https://github.com/anza-xyz/quinn?rev=d8944f6085193cc29e750b40d86d0b5cb4a21831#d8944f6085193cc29e750b40d86d0b5cb4a21831" |
There was a problem hiding this comment.
the patch updates quinn-udp as well. I added a new commit to agave-2.3 so the lockfile looks cleaner.
anza-xyz/quinn@fc4decb
There was a problem hiding this comment.
the patch in quinn repo points to 0.5.5, this points to 0.5.12 - is it ok?
There was a problem hiding this comment.
updated to point at this commit
bw-solana
dismissed stale reviews from gregcusack and alexpyattaev
via
004b303
bw-solana
force-pushed
the
vendor_quinn
branch
from
6637187 to
004b303
Compare
| quinn = { git = "https://github.com/anza-xyz/quinn", rev = "d8944f6085193cc29e750b40d86d0b5cb4a21831" } | ||
| quinn-proto = { git = "https://github.com/anza-xyz/quinn", rev = "d8944f6085193cc29e750b40d86d0b5cb4a21831" } |
There was a problem hiding this comment.
| quinn = { git = "https://github.com/anza-xyz/quinn", rev = "d8944f6085193cc29e750b40d86d0b5cb4a21831" } | |
| quinn-proto = { git = "https://github.com/anza-xyz/quinn", rev = "d8944f6085193cc29e750b40d86d0b5cb4a21831" } | |
| quinn = { git = "https://github.com/anza-xyz/quinn", rev = "fc4decb0cf79b1b210603294e96849d67e9c22e2" } | |
| quinn-proto = { git = "https://github.com/anza-xyz/quinn", rev = "fc4decb0cf79b1b210603294e96849d67e9c22e2" } |
|
not sure why your tree touched sbf's cargo.lock. just created a ci test (#8284) and it's still running ci. |
|
sorry, I’m not sure if we actually use any quinn features in |
it is pulled in by streamer via tests |
|
I thought we were only bumping the root cargo.toml. if we want to include programs/sbf, maybe we can just relax the pin restrictions so that we don't touch the quinn-udp |
Can this be done in a follow-up PR? |
|
I think we will just bp this PR. it's better to do it here. |
Changeset for 0.5.5 is very small and unrelated to agave (mostly android support and CI) |
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
(cherry picked from commit c0f5445)
(cherry picked from commit c0f5445)
5 participants
Problem
See #8262
Summary of Changes
quinn-udpfrom v0.5.4 to v0.5.5