Skip to content

v3.0: program-runtime: drop metrics (backport of #7807)#7827

Merged
buffalojoec merged 1 commit intov3.0from
mergify/bp/v3.0/pr-7807
Sep 4, 2025
Merged

v3.0: program-runtime: drop metrics (backport of #7807)#7827
buffalojoec merged 1 commit intov3.0from
mergify/bp/v3.0/pr-7807

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Sep 2, 2025

Removes the single use of the solana-metrics dependency from program-runtime, ensuring all SVM crates no longer need solana-svm-metrics.


This is an automatic backport of pull request #7807 done by Mergify.

@mergify mergify Bot added the conflicts label Sep 2, 2025
@mergify mergify Bot requested a review from a team as a code owner September 2, 2025 15:26
@mergify mergify Bot added the conflicts label Sep 2, 2025
@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Sep 2, 2025

Cherry-pick of bef3d36 has failed:

On branch mergify/bp/v3.0/pr-7807
Your branch is up to date with 'origin/v3.0'.

You are currently cherry-picking commit bef3d3611.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   program-runtime/src/loaded_programs.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   program-runtime/Cargo.toml
	both modified:   program-runtime/src/lib.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@t-nelson
Copy link
Copy Markdown

t-nelson commented Sep 4, 2025

needs conflict resolution

@buffalojoec
Copy link
Copy Markdown

Requires #7824

program-runtime: remove metrics dependency
@buffalojoec buffalojoec force-pushed the mergify/bp/v3.0/pr-7807 branch from 913e44e to 490c6d2 Compare September 4, 2025 16:58
@buffalojoec
Copy link
Copy Markdown

@t-nelson This should be g2g

@buffalojoec buffalojoec added the automerge automerge Merge this Pull Request automatically once CI passes label Sep 4, 2025
@t-nelson
Copy link
Copy Markdown

t-nelson commented Sep 4, 2025

you better find sme before ci finishes or that automerge is gonna fail 😂

@buffalojoec buffalojoec requested a review from Lichtso September 4, 2025 17:18
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.5%. Comparing base (754b6de) to head (490c6d2).

Additional details and impacted files
@@           Coverage Diff           @@
##             v3.0    #7827   +/-   ##
=======================================
  Coverage    83.4%    83.5%           
=======================================
  Files         810      810           
  Lines      365318   365313    -5     
=======================================
+ Hits       304965   305045   +80     
+ Misses      60353    60268   -85     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@buffalojoec buffalojoec merged commit 602c0e6 into v3.0 Sep 4, 2025
43 checks passed
@buffalojoec buffalojoec deleted the mergify/bp/v3.0/pr-7807 branch September 4, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge automerge Merge this Pull Request automatically once CI passes conflicts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants