Skip to content

program-runtime: drop metrics#7807

Merged
buffalojoec merged 1 commit into
anza-xyz:masterfrom
buffalojoec:program-runtime-drop-metrics
Sep 2, 2025
Merged

program-runtime: drop metrics#7807
buffalojoec merged 1 commit into
anza-xyz:masterfrom
buffalojoec:program-runtime-drop-metrics

Conversation

@buffalojoec
Copy link
Copy Markdown

@buffalojoec buffalojoec commented Aug 30, 2025

Removes the single use of the solana-metrics dependency from program-runtime, ensuring all SVM crates no longer need solana-svm-metrics.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.1%. Comparing base (0c3bf69) to head (c47c353).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #7807     +/-   ##
=========================================
- Coverage    83.1%    83.1%   -0.1%     
=========================================
  Files         808      808             
  Lines      356469   356464      -5     
=========================================
- Hits       296288   296228     -60     
- Misses      60181    60236     +55     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@buffalojoec buffalojoec force-pushed the program-runtime-drop-metrics branch from 54bb8f2 to c47c353 Compare September 2, 2025 11:27
@buffalojoec buffalojoec requested a review from steviez September 2, 2025 11:27
@buffalojoec buffalojoec marked this pull request as ready for review September 2, 2025 11:27
@buffalojoec buffalojoec requested a review from a team as a code owner September 2, 2025 11:27
@steviez steviez added the v3.0 label Sep 2, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented Sep 2, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@buffalojoec buffalojoec merged commit bef3d36 into anza-xyz:master Sep 2, 2025
55 checks passed
mergify Bot pushed a commit that referenced this pull request Sep 2, 2025
program-runtime: remove metrics dependency
(cherry picked from commit bef3d36)

# Conflicts:
#	program-runtime/Cargo.toml
#	program-runtime/src/lib.rs
buffalojoec added a commit that referenced this pull request Sep 4, 2025
program-runtime: remove metrics dependency
buffalojoec added a commit that referenced this pull request Sep 4, 2025
program-runtime: drop metrics (#7807)

program-runtime: remove metrics dependency

Co-authored-by: Joe C <joe.caulfield@anza.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants