Add a first time contributors section to CONTRIBUTING.md#7818
Add a first time contributors section to CONTRIBUTING.md#7818steviez merged 1 commit intoanza-xyz:masterfrom
Conversation
t-nelson
left a comment
There was a problem hiding this comment.
lgtm. seems like there are some detractors on the team. probably give them time to comment something other than kumbayas.
tho i do agree that we should run and add to ci some kind of spelling/grammar checker
Yup, Brooks gave me a ship it this morning but was planning on letting it ride for a couple days
Same here. Jon mentioned that we have this in some other repos; I ran it on Agave shortly before being OoO for a couple days and realized it wasn't something to take on then. Some of my other tedious / linting stuff is wrapping up tho so maybe I can take it on in the background |
apfitzge
left a comment
There was a problem hiding this comment.
LGTM - we definitely should add CI though when we have a chance.
To me it feels slightly wrong to close something that IS an improvement to docs/comments...but it's better to discourage inconsequential shit than let the spam continue.
|
funnily enough I think my first solana PR was a typo in docs I found while ramping up lol: solana-labs#24706 |
Yeah, it will not be a small lift to get this done now. Definitely one of those things that is better to have setup in your brand new repo and enforced as new stuff is added 😅 |
Yeah wonder if we could do some sort of remove-only migration? i.e. we run some cargo spell check command, we generate a file and count the number of spelling mistakes...CI doesn't allow it to increase? That way we can't accidently add typos in new code, and we can incrementally remove the old typos. |
|
Think this has sat long enough and either nobody else has a strong opinion against it or they forgot about it (probably the latter). In any case, going to merge and we'll try things out for a while with this policy. Force pushed to squash the commits |
The addition includes comments that inconsequential changes from first time contributors may be closed at the discretion of Agave maintainers
3e6f70a to
3c1afbb
Compare
Summary of Changes
The addition includes comments that inconsequential changes from first time contributors may be closed at the discretion of Agave maintainers
Fixes #