Skip to content

Add a first time contributors section to CONTRIBUTING.md#7818

Merged
steviez merged 1 commit intoanza-xyz:masterfrom
steviez:contrib_no_more_typos
Oct 15, 2025
Merged

Add a first time contributors section to CONTRIBUTING.md#7818
steviez merged 1 commit intoanza-xyz:masterfrom
steviez:contrib_no_more_typos

Conversation

@steviez
Copy link
Copy Markdown

@steviez steviez commented Sep 2, 2025

Summary of Changes

The addition includes comments that inconsequential changes from first time contributors may be closed at the discretion of Agave maintainers

Fixes #

brooksprumo
brooksprumo previously approved these changes Sep 2, 2025
Comment thread CONTRIBUTING.md Outdated
Copy link
Copy Markdown

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. seems like there are some detractors on the team. probably give them time to comment something other than kumbayas.

tho i do agree that we should run and add to ci some kind of spelling/grammar checker

@steviez
Copy link
Copy Markdown
Author

steviez commented Sep 2, 2025

lgtm. seems like there are some detractors on the team. probably give them time to comment something other than kumbayas.

Yup, Brooks gave me a ship it this morning but was planning on letting it ride for a couple days

tho i do agree that we should run and add to ci some kind of spelling/grammar checker

Same here. Jon mentioned that we have this in some other repos; I ran it on Agave shortly before being OoO for a couple days and realized it wasn't something to take on then. Some of my other tedious / linting stuff is wrapping up tho so maybe I can take it on in the background

Copy link
Copy Markdown

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we definitely should add CI though when we have a chance.
To me it feels slightly wrong to close something that IS an improvement to docs/comments...but it's better to discourage inconsequential shit than let the spam continue.

@apfitzge
Copy link
Copy Markdown

apfitzge commented Sep 5, 2025

funnily enough I think my first solana PR was a typo in docs I found while ramping up lol: solana-labs#24706
think what we'd have lost without this valuable contribution!

@steviez
Copy link
Copy Markdown
Author

steviez commented Sep 9, 2025

LGTM - we definitely should add CI though when we have a chance

Yeah, it will not be a small lift to get this done now. Definitely one of those things that is better to have setup in your brand new repo and enforced as new stuff is added 😅

@apfitzge
Copy link
Copy Markdown

apfitzge commented Sep 9, 2025

Yeah, it will not be a small lift to get this done now. Definitely one of those things that is better to have setup in your brand new repo and enforced as new stuff is added 😅

Yeah wonder if we could do some sort of remove-only migration? i.e. we run some cargo spell check command, we generate a file and count the number of spelling mistakes...CI doesn't allow it to increase? That way we can't accidently add typos in new code, and we can incrementally remove the old typos.

@steviez steviez mentioned this pull request Oct 1, 2025
@steviez
Copy link
Copy Markdown
Author

steviez commented Oct 15, 2025

Think this has sat long enough and either nobody else has a strong opinion against it or they forgot about it (probably the latter). In any case, going to merge and we'll try things out for a while with this policy.

Force pushed to squash the commits

The addition includes comments that inconsequential changes from first
time contributors may be closed at the discretion of Agave maintainers
@steviez steviez force-pushed the contrib_no_more_typos branch from 3e6f70a to 3c1afbb Compare October 15, 2025 05:14
@steviez steviez added this pull request to the merge queue Oct 15, 2025
Merged via the queue into anza-xyz:master with commit 8650813 Oct 15, 2025
9 checks passed
@steviez steviez deleted the contrib_no_more_typos branch October 15, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants