fix: Fix broken links by bobtajson · Pull Request #7721 · anza-xyz/agave

bobtajson · 2025-08-26T10:24:41Z

Problem

Dead link in RELEASE.md
Broken link in spec.md
fixed CSS property in styles.module.css

Summary of Changes

Removed dead link in RELEASE.md
Replaced dead links https://docs.solana.com/validator/runtime#execution and https://docs.solana.com/validator/runtime#execution to
https://docs.anza.xyz/validator/runtime#execution and https://docs.anza.xyz/validator/runtime#execution in spec.md file
Replaced align-items: top to flex-start

Fixes #

dead link

fixed break link

fixed css style

0xbrw · 2025-08-26T19:16:00Z

 [Crates.io agave-validator](https://crates.io/crates/agave-validator) should have an updated agave-validator version.  This can take 2-3 hours, and sometimes fails in the `agave-secondary` job.
 If this happens and the error is non-fatal, click "Retry" on the "publish crate" job

+<!-- TODO: fix this dead link to actual 


@buffalojoec @willhickey do we have a replacement link for cluster-ops?

@willhickey @0xbrw removed link

0xbrw · 2025-08-26T19:16:06Z

 .features {
  display: flex;
-  align-items: top;
+  align-items: flex-start;


can you include a screenshot of the before and after change?

This code is not currently in use. I don't know if it's leftover from the past or planned for the future, but if it gets implemented, it could cause layout issues on different screen sizes.

can you include a screenshot of the before and after change?

Yes, it is not used anywhere. I can look for properties that are not yet used and make one more commit without them

if this code is not in use, lets remove this change from the PR

@willhickey

0xbrw

Let’s place a hold on this until we know what to replace cluster-ops links with

bobtajson · 2025-08-27T16:58:09Z

Let’s place a hold on this until we know what to replace cluster-ops links with

ChatGPT telling me this:

Why is validator the right place to look if you’re seeking a working equivalent of cluster-ops?

The cluster-ops repository (Solana Labs) provided tools for managing a cluster of validators (i.e., cluster operations).

In Agave, the role of such tooling is implemented directly within the shared validator code and its surrounding environment, including the validator directory and the supporting infrastructure such as documentation, CLI commands, configuration management, and operational controls.

https://github.com/anza-xyz/agave/tree/master/validator

So if you agree, i will commit this link to placeholder

willhickey · 2025-08-27T18:19:41Z

 ### Update software on testnet.solana.com
 See the documentation at https://github.com/solana-labs/cluster-ops/. devnet.solana.com and mainnet-beta.solana.com run stable releases that have been tested on testnet. Do not update devnet or mainnet-beta with a beta release.


We don't have any public documentation that replaces cluster-ops. I suggest removing this sentence:

See the documentation at https://github.com/solana-labs/cluster-ops/.

willhickey · 2025-08-29T14:27:22Z

The two .md file changes are fine, but I haven't confirmed that deleting the css file is ok. @0xbrw have you checked the css deletion?

bobtajson · 2025-08-29T14:38:17Z

The two .md file changes are fine, but I haven't confirmed that deleting the css file is ok. @0xbrw have you checked the css deletion?

yeah he checked, i taged you under that commit

bobtajson · 2025-09-13T10:44:33Z

@0xbrw so can we merge this?

0xbrw · 2025-09-18T19:48:08Z

@0xbrw so can we merge this?

Can you revert the CSS file deletion and update the PR title/description to represent the new changes

bobtajson · 2025-09-29T06:54:24Z

@0xbrw so can we merge this?

Can you revert the CSS file deletion and update the PR title/description to represent the new changes

Title and description updated, but i can't revert CSS file because it was remove from your master branch

willhickey · 2025-09-29T16:29:03Z

Title and description updated, but i can't revert CSS file because it was remove from your master branch

It's still there:
https://github.com/anza-xyz/agave/tree/master/docs/src/pages

There's a few ways to undo the delete. A checkout followed by a commit will preserve the existing history here:
git checkout master -- docs/src/pages/styles.module.css

bobtajson · 2025-09-30T06:09:42Z

Title and description updated, but i can't revert CSS file because it was remove from your master branch

It's still there: https://github.com/anza-xyz/agave/tree/master/docs/src/pages

There's a few ways to undo the delete. A checkout followed by a commit will preserve the existing history here: git checkout master -- docs/src/pages/styles.module.css

done

willhickey

The two changes in md files are fine. I'm not familiar with the docs css so don't have an opinion on that change.

0xbrw · 2025-09-30T15:59:43Z

 .features {
  display: flex;
-  align-items: top;
+  align-items: flex-start;


I still see changes in this css file. Can you pull the latest changes from the master branch and then run:
git checkout master -- docs/src/pages/styles.module.css

So i'm confused, i need to delete this file from my PR?

yes if it is not in use and you cannot confirm the before and after changes.

steviez · 2025-10-01T15:58:36Z

Closing this PR for several reasons:

I'd consider this PR to fall into what is covered in Add a first time contributors section to CONTRIBUTING.md #7818
This has been an awful amount of conversation to try to get two lines of docs updates merged
- We welcome external contributions, but we also have limited time and need to use that time wisely

bobtajson added 3 commits August 26, 2025 12:59

Update RELEASE.md

fcd4cc8

dead link

Update spec.md

f195f30

fixed break link

Update styles.module.css

ee4810b

fixed css style

bobtajson requested a review from a team as a code owner August 26, 2025 10:24

mergify Bot added community need:merge-assist labels Aug 26, 2025

LucasSte requested review from 0xbrw and steviez August 26, 2025 14:37

0xbrw requested changes Aug 26, 2025

View reviewed changes

bobtajson added 2 commits August 27, 2025 00:23

Delete docs/src/pages/styles.module.css

3414982

Merge branch 'anza-xyz:master' into master

0fcca69

0xbrw requested changes Aug 27, 2025

View reviewed changes

willhickey reviewed Aug 27, 2025

View reviewed changes

bobtajson added 2 commits August 27, 2025 23:13

Update RELEASE.md

f7af218

Merge branch 'anza-xyz:master' into master

c33a70d

bobtajson requested review from 0xbrw and willhickey August 29, 2025 12:28

bobtajson changed the title ~~fix: Fix broken links and CSS property~~ fix: Fix broken links Sep 29, 2025

Create styles.module.css

7d6925e

willhickey reviewed Sep 30, 2025

View reviewed changes

0xbrw requested changes Sep 30, 2025

View reviewed changes

steviez closed this Oct 1, 2025

		### Update software on testnet.solana.com
		See the documentation at https://github.com/solana-labs/cluster-ops/. devnet.solana.com and mainnet-beta.solana.com run stable releases that have been tested on testnet. Do not update devnet or mainnet-beta with a beta release.

Conversation

bobtajson commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Summary of Changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bobtajson Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xbrw left a comment

Choose a reason for hiding this comment

Uh oh!

bobtajson commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

willhickey commented Aug 29, 2025

Uh oh!

bobtajson commented Aug 29, 2025

Uh oh!

bobtajson commented Sep 13, 2025

Uh oh!

0xbrw commented Sep 18, 2025

Uh oh!

bobtajson commented Sep 29, 2025

Uh oh!

willhickey commented Sep 29, 2025

Uh oh!

bobtajson commented Sep 30, 2025

Uh oh!

willhickey left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

steviez commented Oct 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bobtajson commented Aug 26, 2025 •

edited

Loading

bobtajson Aug 26, 2025 •

edited

Loading

bobtajson commented Aug 27, 2025 •

edited

Loading