Votor integration2#7802
Closed
bw-solana wants to merge 11 commits intoanza-xyz:masterfrom
Closed
Conversation
|
The Firedancer team maintains a line-for-line reimplementation of the |
Closed
4369c52 to
043dab1
Compare
464dc00 to
7b83e1d
Compare
AshwinSekar
reviewed
Aug 30, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7802 +/- ##
=========================================
- Coverage 83.0% 82.7% -0.4%
=========================================
Files 812 834 +22
Lines 357003 362299 +5296
=========================================
+ Hits 296616 299819 +3203
- Misses 60387 62480 +2093 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Need to upstream votor and votor-messages crates to bring in a ton of Alpenglow functionality.
This replaces #7781
Summary of Changes
votorandvotor-messagescrates as is from Alpenglow repoVersionedEpochStakesto include BLS pubkey ranksSharableBanksintegration conflictsbytemuck-deriveinvotor-messagesVersionedEpochStakeschanges trigger thissolana-bls-signaturesdep when running miri big endian test for votes (dependent on blst, which doesn't work w/ big endian)VoteStateV4missing APIs and configurability for testsTODOs Completed:
VersionedEpochStakesso we can avoid changing the Frozen-ABI. See Do not serialize/deserialize bls_pubkey_to_rank_map. alpenglow#431TODOs:
VoteStateV4hacks to a level we are comfortable with or wait for full support insolana-vote-interfacefor serdes, size discovery, etc.