Skip to content

Votor integration2#7802

Closed
bw-solana wants to merge 11 commits intoanza-xyz:masterfrom
bw-solana:votor_integration2
Closed

Votor integration2#7802
bw-solana wants to merge 11 commits intoanza-xyz:masterfrom
bw-solana:votor_integration2

Conversation

@bw-solana
Copy link
Copy Markdown

@bw-solana bw-solana commented Aug 29, 2025

Problem

Need to upstream votor and votor-messages crates to bring in a ton of Alpenglow functionality.

This replaces #7781

Summary of Changes

  • Copy over the votor and votor-messages crates as is from Alpenglow repo
  • Add blockstore columns for certificates
  • Update VersionedEpochStakes to include BLS pubkey ranks
  • Resolve SharableBanks integration conflicts
  • Use bytemuck-derive in votor-messages
  • Update Bank Frozen ABI and plumbing because VersionedEpochStakes changes trigger this
  • Disable solana-bls-signatures dep when running miri big endian test for votes (dependent on blst, which doesn't work w/ big endian)
  • Hack in VoteStateV4 missing APIs and configurability for tests
  • Fix Doctest bug

TODOs Completed:

TODOs:

  • Clean up the VoteStateV4 hacks to a level we are comfortable with or wait for full support in solana-vote-interface for serdes, size discovery, etc.

@mergify
Copy link
Copy Markdown

mergify Bot commented Aug 29, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@bw-solana bw-solana mentioned this pull request Aug 29, 2025
Comment thread votor-messages/src/accounting.rs Outdated
Comment thread votor-messages/src/bls_message.rs Outdated
Comment thread votor-messages/src/instruction.rs Outdated
Comment thread votor-messages/src/lib.rs Outdated
Comment thread votor-messages/src/state.rs Outdated
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 30, 2025

Codecov Report

❌ Patch coverage is 61.79690% with 2024 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.7%. Comparing base (c9c232c) to head (b9eacb1).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #7802     +/-   ##
=========================================
- Coverage    83.0%    82.7%   -0.4%     
=========================================
  Files         812      834     +22     
  Lines      357003   362299   +5296     
=========================================
+ Hits       296616   299819   +3203     
- Misses      60387    62480   +2093     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was referenced Aug 31, 2025
This was referenced Aug 31, 2025
@bw-solana bw-solana closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants