Skip to content

Upstream Votor#7781

Closed
bw-solana wants to merge 14 commits intoanza-xyz:masterfrom
bw-solana:votor_integration
Closed

Upstream Votor#7781
bw-solana wants to merge 14 commits intoanza-xyz:masterfrom
bw-solana:votor_integration

Conversation

@bw-solana
Copy link
Copy Markdown

Problem

Summary of Changes

Fixes #

@mergify
Copy link
Copy Markdown

mergify Bot commented Aug 29, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.63660% with 2226 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.6%. Comparing base (c9c232c) to head (ed3726f).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #7781     +/-   ##
=========================================
- Coverage    83.0%    82.6%   -0.5%     
=========================================
  Files         812      837     +25     
  Lines      357003   361184   +4181     
=========================================
+ Hits       296616   298553   +1937     
- Misses      60387    62631   +2244     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread ledger/src/blockstore.rs
perf_samples_cf: LedgerColumn<cf::PerfSamples>,
rewards_cf: LedgerColumn<cf::Rewards>,
roots_cf: LedgerColumn<cf::Root>,
slot_certificates_cf: LedgerColumn<cf::SlotCertificates>,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can rework to remove this before upstreaming to master, it's not needed (an artifact from when we wanted certificate repair)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bw-solana bw-solana mentioned this pull request Aug 29, 2025
@bw-solana bw-solana closed this Aug 29, 2025
@bw-solana
Copy link
Copy Markdown
Author

Closed in favor of #7802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants