Skip to content

Fix release build compilation error #7329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fkouteib merged 1 commit into from
Aug 5, 2025
Merged

Fix release build compilation error #7329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/src/banking_stage/transaction_scheduler/greedy_scheduler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ impl<Tx: TransactionWithMeta> Scheduler<Tx> for GreedyScheduler<Tx> {
});
}

#[cfg(debug_assertions)]
debug_assert!(
self.common.batches.is_empty(),
"batches must start empty for scheduling"
Expand Down
1 change: 1 addition & 0 deletions core/src/banking_stage/transaction_scheduler/prio_graph_scheduler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ impl<Tx: TransactionWithMeta> Scheduler<Tx> for PrioGraphScheduler<Tx> {
// Check transactions against filter, remove from container if it fails.
chunked_pops(container, &mut self.prio_graph, &mut window_budget);

#[cfg(debug_assertions)]
Copy link
Copy Markdown

@apfitzge apfitzge Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this implied by debug_assert???

Copy link
Copy Markdown
Author

@fkouteib fkouteib Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I assumed too, but the build error and docs say otherwise. From Rust docs, "The result of expanding debug_assert! is always type checked."

Copy link
Copy Markdown

@apfitzge apfitzge Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's annoying

Copy link
Copy Markdown

@steviez steviez Sep 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this implied by debug_assert???
...
That's what I assumed too

git blame led me here and same, would not have expected to have to add the extra markup:
https://doc.rust-lang.org/src/core/macros/mod.rs.html#306-312

To clarify, no actions being requested by me, I'm just sharing in your surprise a month late 😆

debug_assert!(
self.common.batches.is_empty(),
"batches must start empty for scheduling"
Expand Down
Loading