Fix release build compilation error

[fkouteib]

Problem

"./cargo build --release" fails with compilation error over a cfg guard added in this PR.

[error[E0599]:] no method named is_empty found for struct Batches in the current scope
--> core/src/banking_stage/transaction_scheduler/prio_graph_scheduler.rs:200:33
|
200 | self.common.batches.is_empty(),
| ^^^^^^^^ method not found in Batches<Tx>
|
::: core/src/banking_stage/transaction_scheduler/scheduler_common.rs:21:1
|
21 | pub struct Batches {
| ---------------------- method is_empty not found for this struct

Summary of Changes

Add cfg guard to the method invokations because the compiler doesn't ignore/skip checks inside debug_assert!() on release build. Alternatively, I can remove the cfg guard on the method definition.

[apfitzge]

Isn't this implied by debug_assert???

[fkouteib]

That's what I assumed too, but the build error and docs say otherwise. From Rust docs, "The result of expanding debug_assert! is always type checked."

[apfitzge]

that's annoying

[steviez]

Isn't this implied by debug_assert???
...
That's what I assumed too

git blame led me here and same, would not have expected to have to add the extra markup:
https://doc.rust-lang.org/src/core/macros/mod.rs.html#306-312

To clarify, no actions being requested by me, I'm just sharing in your surprise a month late 😆

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.0%. Comparing base (e5eb344) to head (165995a).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7329   +/-   ##
=======================================
  Coverage    83.0%    83.0%           
=======================================
  Files         801      801           
  Lines      362242   362244    +2     
=======================================
+ Hits       300789   300802   +13     
+ Misses      61453    61442   -11     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[apfitzge]

fine workaround for an annoying aspect of rust's debug_assert.