Removes test_hash_calculation from AccountsBackgroundService handle_snapshot_requests()#6988
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Jul 16, 2025
Conversation
…napshot_requests()
brooksprumo
commented
Jul 16, 2025
Comment on lines
-604
to
-608
| request_handlers.handle_snapshot_requests( | ||
| false, // test_hash_calculation. Will be removed soon. | ||
| non_snapshot_time, | ||
| &exit, | ||
| ) |
Author
There was a problem hiding this comment.
Here's the start/main change: test_hash_calculation is always false, so we can remove the param.
| &snapshot_root_bank, | ||
| snapshot_storages, | ||
| status_cache_slot_deltas, | ||
| accounts_hash_for_testing, |
Author
There was a problem hiding this comment.
accounts_hash_for_testing is always None because up on line 330 previous_accounts_hash is also always None, because up on line 203 test_hash_calculation is always false. So we remove accounts_hash_for_testing too.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6988 +/- ##
=======================================
Coverage 83.2% 83.2%
=======================================
Files 853 853
Lines 375531 375482 -49
=======================================
- Hits 312586 312566 -20
+ Misses 62945 62916 -29 🚀 New features to boost your workflow:
|
roryharr
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
test_hash_calculationparameter to AccountsBackgroundService'shandle_snapshot_requests()is unused and should be removed.Summary of Changes
Remove the param, then update all the callers.