Removes AccountsPackageKind::EpochAccountsHash#7000
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Jul 16, 2025
Merged
Removes AccountsPackageKind::EpochAccountsHash#7000brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo merged 1 commit intoanza-xyz:masterfrom
Conversation
brooksprumo
force-pushed
the
lthash/215/accounts-package-kind
branch
from
f745d8b to
b1eccc9
Compare
brooksprumo
commented
Jul 16, 2025
| #[derive(Debug, Copy, Clone, Eq, PartialEq)] | ||
| pub enum AccountsPackageKind { | ||
| Snapshot(SnapshotKind), | ||
| EpochAccountsHash, |
| pub enum SnapshotRequestKind { | ||
| FullSnapshot, | ||
| IncrementalSnapshot, | ||
| EpochAccountsHash, |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7000 +/- ##
=========================================
- Coverage 83.2% 83.2% -0.1%
=========================================
Files 853 853
Lines 375401 375115 -286
=========================================
- Hits 312545 312204 -341
- Misses 62856 62911 +55 🚀 New features to boost your workflow:
|
HaoranYi
reviewed
Jul 16, 2025
| // By asking for the second-to-last element to be in its final sorted position, we | ||
| // also ensure that the last element is also sorted. | ||
| let (_, y, z) = accounts_packages.select_nth_unstable_by( | ||
| // Note, we no longer need the second-to-last element; this code can be refactored. |
roryharr
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The epoch accounts hash has been removed, so there are no more snapshot requests to calculate the EAH. The EAH request kind for AccountsBackgroundService and AccountsHashVerifier can be removed.
Summary of Changes
Removes SnapshotRequestKind::EpochAccountsHash and AccountsPackageKind::EpochAccountsHash.