Skip to content

vote-interface: explicitly use v3 everywhere#6987

Merged
buffalojoec merged 1 commit intoanza-xyz:masterfrom
buffalojoec:vote-state-explicit-v3
Jul 16, 2025
Merged

vote-interface: explicitly use v3 everywhere#6987
buffalojoec merged 1 commit intoanza-xyz:masterfrom
buffalojoec:vote-state-explicit-v3

Conversation

@buffalojoec
Copy link
Copy Markdown

@buffalojoec buffalojoec commented Jul 16, 2025

Problem

After anza-xyz/solana-sdk#221, the solana-vote-interface crate now explicitly names vote_state_v3::VoteState to vote_state_v3::VoteStateV3. In preparation for the upcoming vote state v4, we should go through the monorepo and update all callsites to use VoteStateV3 explicitly.

Summary of Changes

Update all callsites to use VoteStateV3 explicitly.

@mergify
Copy link
Copy Markdown

mergify Bot commented Jul 16, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@buffalojoec buffalojoec marked this pull request as ready for review July 16, 2025 02:42
@buffalojoec buffalojoec requested a review from jstarry July 16, 2025 02:42
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.2%. Comparing base (6bc9fb1) to head (bd49e86).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6987     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         856      856             
  Lines      376426   376429      +3     
=========================================
- Hits       313321   313280     -41     
- Misses      63105    63149     +44     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look great!

@buffalojoec buffalojoec merged commit c326eff into anza-xyz:master Jul 16, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants