Skip to content

[WIP]: vote-interface: explicitly use v3 everywhere#6759

Closed
buffalojoec wants to merge 2 commits intoanza-xyz:masterfrom
buffalojoec:wip-vote-state-v4-hk
Closed

[WIP]: vote-interface: explicitly use v3 everywhere#6759
buffalojoec wants to merge 2 commits intoanza-xyz:masterfrom
buffalojoec:wip-vote-state-v4-hk

Conversation

@buffalojoec
Copy link
Copy Markdown

Builds on the back of anza-xyz/solana-sdk#206.

Basically assumes we'd publish those changes in a new solana-vote-interface version, and demonstrates updating the dependency to Agave to use the new version.

Note we would explicitly use "v3" everywhere, which leaves the validator (and stake & vote program) functionally unchanged.

@buffalojoec buffalojoec requested a review from jstarry June 27, 2025 06:27
@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 27, 2025

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/kit (example)

Thank you for keeping the RPC clients in sync with the server API @buffalojoec.

@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 27, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@buffalojoec buffalojoec added the noCI Suppress CI on this Pull Request label Jun 30, 2025
Copy link
Copy Markdown

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the right direction to me! let's get those sdk changes in

@buffalojoec
Copy link
Copy Markdown
Author

Closed in favor of #6987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

noCI Suppress CI on this Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants