[WIP]: vote-interface: explicitly use v3 everywhere#6759
Closed
buffalojoec wants to merge 2 commits intoanza-xyz:masterfrom
Closed
[WIP]: vote-interface: explicitly use v3 everywhere#6759buffalojoec wants to merge 2 commits intoanza-xyz:masterfrom
buffalojoec wants to merge 2 commits intoanza-xyz:masterfrom
Conversation
|
If this PR represents a change to the public RPC API:
Thank you for keeping the RPC clients in sync with the server API @buffalojoec. |
|
The Firedancer team maintains a line-for-line reimplementation of the |
jstarry
reviewed
Jul 8, 2025
jstarry
left a comment
There was a problem hiding this comment.
looks like the right direction to me! let's get those sdk changes in
Author
|
Closed in favor of #6987 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on the back of anza-xyz/solana-sdk#206.
Basically assumes we'd publish those changes in a new
solana-vote-interfaceversion, and demonstrates updating the dependency to Agave to use the new version.Note we would explicitly use "v3" everywhere, which leaves the validator (and stake & vote program) functionally unchanged.