Skip to content

accounts-db: Resolve Rust 1.88 clippy lints and format strings#6963

Merged
steviez merged 4 commits intoanza-xyz:masterfrom
steviez:rust_1.88_accounts-db
Jul 15, 2025
Merged

accounts-db: Resolve Rust 1.88 clippy lints and format strings#6963
steviez merged 4 commits intoanza-xyz:masterfrom
steviez:rust_1.88_accounts-db

Conversation

@steviez
Copy link
Copy Markdown

@steviez steviez commented Jul 14, 2025

Problem

Working towards #6850, broken out from #6854

Summary of Changes

  • Run cargo clippy --fix --tests with Rust 1.88.0 set in rust-toolchain.toml
    • These should only be instances of uninlined_format_args
  • Run cargo fmt with format_strings = true set in rustfmt.toml

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 14, 2025

Codecov Report

Attention: Patch coverage is 77.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 83.2%. Comparing base (4807a7a) to head (3d6a4ad).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6963     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         856      856             
  Lines      376390   376393      +3     
=========================================
- Hits       313281   313274      -7     
- Misses      63109    63119     +10     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread accounts-db/src/hardened_unpack.rs Outdated
Comment thread bucket_map/src/bucket_storage.rs Outdated
Copy link
Copy Markdown

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Copy Markdown

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@steviez steviez merged commit 6763a69 into anza-xyz:master Jul 15, 2025
41 checks passed
@steviez steviez deleted the rust_1.88_accounts-db branch July 15, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants