Skip to content

ci(windows): use vcpkg to install openssl 3.4.1#6824

Merged
yihau merged 2 commits intoanza-xyz:masterfrom
yihau:use-vcpkg-for-windows
Jul 3, 2025
Merged

ci(windows): use vcpkg to install openssl 3.4.1#6824
yihau merged 2 commits intoanza-xyz:masterfrom
yihau:use-vcpkg-for-windows

Conversation

@yihau
Copy link
Copy Markdown
Member

@yihau yihau commented Jul 3, 2025

Problem

slproweb doesn’t guarantee that libraries will be hosted indefinitely. if they remove any version unexpectedly, it could break our pipeline

Summary of Changes

  • compile via vcpkg

note: this reverts the OpenSSL version bump I made in #6804 (from 3.4.1 -> 3.4.2). It’s also simpler for backports. we can bump master's version with another PR

@yihau yihau requested review from mircea-c and t-nelson July 3, 2025 12:08
@yihau yihau added v2.2 labels Jul 3, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented Jul 3, 2025

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

@mergify
Copy link
Copy Markdown

mergify Bot commented Jul 3, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

Comment thread .github/scripts/install-openssl.sh
Comment thread .github/scripts/install-openssl.sh Outdated
Copy link
Copy Markdown

@mircea-c mircea-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@yihau yihau merged commit a164bb6 into anza-xyz:master Jul 3, 2025
36 checks passed
mergify Bot pushed a commit that referenced this pull request Jul 3, 2025
mergify Bot pushed a commit that referenced this pull request Jul 3, 2025
yihau added a commit that referenced this pull request Jul 7, 2025
) (#6834)

ci(windows): use vcpkg to install openssl 3.4.1 (#6824)

(cherry picked from commit a164bb6)

Co-authored-by: Yihau Chen <yihau.chen@icloud.com>
yihau added a commit that referenced this pull request Jul 7, 2025
) (#6833)

ci(windows): use vcpkg to install openssl 3.4.1 (#6824)

(cherry picked from commit a164bb6)

Co-authored-by: Yihau Chen <yihau.chen@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants