Skip to content

ci: install openssl 3.4.2 for windows clippy build#6804

Merged
yihau merged 2 commits intoanza-xyz:masterfrom
yihau:fix-windows-build
Jul 2, 2025
Merged

ci: install openssl 3.4.2 for windows clippy build#6804
yihau merged 2 commits intoanza-xyz:masterfrom
yihau:fix-windows-build

Conversation

@yihau
Copy link
Copy Markdown
Member

@yihau yihau commented Jul 2, 2025

Problem

openssl 3.4.1 has been removed by the provider and replaced with the latest patch release, 3.4.2. the openssl binaries are hosted by SLProWeb. however they remove old versions quite quickly, while updates on chocolatey are often delayed.

Summary of Changes

download the bins from their web directly

@yihau yihau force-pushed the fix-windows-build branch 2 times, most recently from 3978be1 to 8d15c75 Compare July 2, 2025 03:32
@yihau yihau force-pushed the fix-windows-build branch from 8d15c75 to a75ebc2 Compare July 2, 2025 03:37
@yihau yihau marked this pull request as ready for review July 2, 2025 04:20
@yihau yihau added v2.2 labels Jul 2, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented Jul 2, 2025

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

@mergify
Copy link
Copy Markdown

mergify Bot commented Jul 2, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@yihau yihau requested a review from willhickey July 2, 2025 04:22
Copy link
Copy Markdown
Member

@vadorovsky vadorovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need it for my PRs to become green 🙂

@yihau yihau merged commit ebfb7c2 into anza-xyz:master Jul 2, 2025
38 checks passed
mergify Bot pushed a commit that referenced this pull request Jul 2, 2025
* ci: install openssl 3.4.2 for windows clippy build

* get rid of choco

(cherry picked from commit ebfb7c2)
mergify Bot pushed a commit that referenced this pull request Jul 2, 2025
* ci: install openssl 3.4.2 for windows clippy build

* get rid of choco

(cherry picked from commit ebfb7c2)
@yihau yihau deleted the fix-windows-build branch July 2, 2025 12:00
gregcusack pushed a commit that referenced this pull request Jul 2, 2025
* ci: install openssl 3.4.2 for windows clippy build

* get rid of choco
t-nelson pushed a commit that referenced this pull request Jul 3, 2025
…6804) (#6812)

ci: install openssl 3.4.2 for windows clippy build (#6804)

* ci: install openssl 3.4.2 for windows clippy build

* get rid of choco

(cherry picked from commit ebfb7c2)

Co-authored-by: Yihau Chen <yihau.chen@icloud.com>
t-nelson pushed a commit that referenced this pull request Jul 3, 2025
…6804) (#6811)

ci: install openssl 3.4.2 for windows clippy build (#6804)

* ci: install openssl 3.4.2 for windows clippy build

* get rid of choco

(cherry picked from commit ebfb7c2)

Co-authored-by: Yihau Chen <yihau.chen@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants