v2.3: Fixes AppendVecError::SizeMismatch error message (backport of #6792)#6795
Merged
brooksprumo merged 1 commit intov2.3from Jul 1, 2025
Merged
v2.3: Fixes AppendVecError::SizeMismatch error message (backport of #6792)#6795brooksprumo merged 1 commit intov2.3from
brooksprumo merged 1 commit intov2.3from
Conversation
(cherry picked from commit 898b76e)
HaoranYi
approved these changes
Jul 1, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2.3 #6795 +/- ##
=========================================
- Coverage 82.8% 82.8% -0.1%
=========================================
Files 850 850
Lines 379636 379636
=========================================
- Hits 314582 314536 -46
- Misses 65054 65100 +46 🚀 New features to boost your workflow:
|
t-nelson
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #6552 added a new AppendVecError variant, but the error message has the wrong variable indexes 🤦.
Summary of Changes
Fix 'em.
Justification to Backport
Since PR #6552 was backported to v2.3, we have the same bug here. To be a useful error message, we need this patch.
This is an automatic backport of pull request #6792 done by [Mergify](https://mergify.com).