Skip to content

Fixes AppendVecError::SizeMismatch error message#6792

Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:append-vec/size-mismatch
Jul 1, 2025
Merged

Fixes AppendVecError::SizeMismatch error message#6792
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:append-vec/size-mismatch

Conversation

@brooksprumo
Copy link
Copy Markdown

@brooksprumo brooksprumo commented Jul 1, 2025

Problem

PR #6552 added a new AppendVecError variant, but the error message has the wrong variable indexes 🤦.

Summary of Changes

Fix 'em.

@brooksprumo brooksprumo self-assigned this Jul 1, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented Jul 1, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@brooksprumo brooksprumo marked this pull request as ready for review July 1, 2025 15:34
@brooksprumo brooksprumo requested review from HaoranYi and roryharr July 1, 2025 15:34
Copy link
Copy Markdown

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.3%. Comparing base (0f647dd) to head (2771096).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6792   +/-   ##
=======================================
  Coverage    83.3%    83.3%           
=======================================
  Files         853      853           
  Lines      378185   378185           
=======================================
+ Hits       315296   315351   +55     
+ Misses      62889    62834   -55     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brooksprumo brooksprumo merged commit 898b76e into anza-xyz:master Jul 1, 2025
42 checks passed
@brooksprumo brooksprumo deleted the append-vec/size-mismatch branch July 1, 2025 16:10
mergify Bot pushed a commit that referenced this pull request Jul 1, 2025
brooksprumo added a commit that referenced this pull request Jul 1, 2025
…6792) (#6795)

Fixes AppendVecError::SizeMismatch error message (#6792)

(cherry picked from commit 898b76e)

Co-authored-by: Brooks <brooks@anza.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants