v2.3: Removes unused parameter from AccountsDb::new_existing() (backport of #6543)#6580
Merged
brooksprumo merged 1 commit intov2.3from Jun 13, 2025
Merged
v2.3: Removes unused parameter from AccountsDb::new_existing() (backport of #6543)#6580brooksprumo merged 1 commit intov2.3from
brooksprumo merged 1 commit intov2.3from
Conversation
(cherry picked from commit 69e749e)
roryharr
approved these changes
Jun 13, 2025
t-nelson
approved these changes
Jun 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2.3 #6580 +/- ##
=========================================
- Coverage 82.8% 82.8% -0.1%
=========================================
Files 848 848
Lines 379552 379542 -10
=========================================
- Hits 314532 314386 -146
- Misses 65020 65156 +136 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AccountsDb::new_existing()has an unused parameter,num_accounts, that can be removed.Summary of Changes
Remove it.
Justification to Backport
The #6579 backport PR depends on it. If we do not want to backport 6579, then we do not need to backport this PR.
This is an automatic backport of pull request #6543 done by [Mergify](https://mergify.com).