Skip to content

Removes unused parameter from AccountsDb::new_existing()#6543

Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:new-existing
Jun 12, 2025
Merged

Removes unused parameter from AccountsDb::new_existing()#6543
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:new-existing

Conversation

@brooksprumo
Copy link
Copy Markdown

Problem

AccountsDb::new_existing() has an unused parameter, num_accounts, that can be removed.

Summary of Changes

Remove it.

@brooksprumo brooksprumo added the CI Pull Request is ready to enter CI label Jun 12, 2025
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Jun 12, 2025
@brooksprumo brooksprumo marked this pull request as ready for review June 12, 2025 18:35
@brooksprumo brooksprumo requested review from HaoranYi and roryharr June 12, 2025 18:35
@brooksprumo brooksprumo added the automerge automerge Merge this Pull Request automatically once CI passes label Jun 12, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 12, 2025

automerge label removed due to a CI failure

@mergify mergify Bot removed the automerge automerge Merge this Pull Request automatically once CI passes label Jun 12, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.8%. Comparing base (2ac2f8e) to head (adc07d8).
⚠️ Report is 3170 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6543       +/-   ##
===========================================
+ Coverage        0    82.8%    +82.8%     
===========================================
  Files           0      849      +849     
  Lines           0   379196   +379196     
===========================================
+ Hits            0   314132   +314132     
- Misses          0    65064    +65064     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brooksprumo brooksprumo merged commit 69e749e into anza-xyz:master Jun 12, 2025
32 checks passed
@brooksprumo brooksprumo deleted the new-existing branch June 12, 2025 19:16
@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 13, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify Bot pushed a commit that referenced this pull request Jun 13, 2025
brooksprumo added a commit that referenced this pull request Jun 13, 2025
…ort of #6543) (#6580)

Removes unused parameter from AccountsDb::new_existing() (#6543)

(cherry picked from commit 69e749e)

Co-authored-by: Brooks <brooks@anza.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants