Skip to content

add change to CHANGELOG for #6023#6395

Merged
tao-stones merged 3 commits into
anza-xyz:masterfrom
tao-stones:update-changelog-for-6023
Jun 13, 2025
Merged

add change to CHANGELOG for #6023#6395
tao-stones merged 3 commits into
anza-xyz:masterfrom
tao-stones:update-changelog-for-6023

Conversation

@tao-stones
Copy link
Copy Markdown

Problem

Realized #6023 that added a new field to simulateTransaction result may deserve an entry in changelog

Summary of Changes

  • add to changelog. No updates required.

Fixes #

@tao-stones tao-stones requested review from steviez and willhickey June 3, 2025 16:39
@tao-stones
Copy link
Copy Markdown
Author

@steviez @willhickey lost track of this one -- does this need to be included in 2.3?

@steviez
Copy link
Copy Markdown

steviez commented Jun 12, 2025

@steviez @willhickey lost track of this one -- does this need to be included in 2.3?

Uhh, probably; the change landed in v2.3 right ? Also, I forget where these docs live, but would probably be good to update them as well:
https://solana.com/docs/rpc/http/simulatetransaction

@tao-stones
Copy link
Copy Markdown
Author

tao-stones commented Jun 12, 2025

the change landed in v2.3 right?

Yes

Also, I forget where these docs live, but would probably be good to update them as well: https://solana.com/docs/rpc/http/simulatetransaction

Good call! Quick search didn't find where the docs are. I will dig/ask, then submit change in separate pr.

edit: looks like the doc is under solana-foundation repo; John Liu will do update when it's live on devnet.

@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 12, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

Comment thread CHANGELOG.md Outdated
@tao-stones tao-stones requested a review from steviez June 12, 2025 21:02
Copy link
Copy Markdown

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tao-stones tao-stones merged commit 6fd29a3 into anza-xyz:master Jun 13, 2025
10 checks passed
@tao-stones tao-stones deleted the update-changelog-for-6023 branch June 13, 2025 00:32
mergify Bot pushed a commit that referenced this pull request Jun 13, 2025
* add change to CHANGELOG for #6023

* put under RPC section

* rewording

(cherry picked from commit 6fd29a3)
tao-stones added a commit that referenced this pull request Jun 13, 2025
add change to CHANGELOG for #6023 (#6395)

* add change to CHANGELOG for #6023

* put under RPC section

* rewording

(cherry picked from commit 6fd29a3)

Co-authored-by: Tao Zhu <82401714+tao-stones@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants