This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add client options env var to testnet-automation#6023
Closed
danpaul000 wants to merge 4 commits into
Closed
Conversation
pgarg66
previously approved these changes
Sep 23, 2019
mergify
Bot
dismissed
pgarg66’s stale review
Pull request has been modified.
Contributor
Author
Contributor
|
@danpaul000, finish it or merge it? |
t-nelson
reviewed
Oct 15, 2019
| echo --- start "$nodeCount" node test | ||
| if [[ -n $USE_PREBUILT_CHANNEL_TARBALL ]]; then | ||
| net/net.sh start -f "cuda" -o noValidatorSanity -t "$CHANNEL" | ||
| net/net.sh start -f "cuda" -o noValidatorSanity -t "$CHANNEL" -c bench-tps=1="--tx_count 50000 --thread-batch-sleep-ms 1000" |
Contributor
There was a problem hiding this comment.
-c 'bench-tps=1="--tx_count 50000 --thread-batch-sleep-ms 1000"' oughta do it I'd think
Contributor
Author
|
This fix got addressed when I implemented the nightly perf testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We need a way to set client options from the testnet-automation pipeline
Summary of Changes
Add it. Also, set the default options in the pipeline: https://buildkite.com/solana-labs/solana-testnet/settings
Fixes #