bump rust nightly to 2025-02-16#6073
Merged
yihau merged 2 commits intoanza-xyz:masterfrom May 4, 2025
Merged
Conversation
yihau
force-pushed
the
bump-nightly-rust-2025-02-16
branch
from
fe03ec3 to
eb9203e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6073 +/- ##
=======================================
Coverage 82.9% 82.9%
=======================================
Files 840 840
Lines 377958 377945 -13
=======================================
+ Hits 313372 313381 +9
+ Misses 64586 64564 -22 🚀 New features to boost your workflow:
|
brooksprumo
reviewed
May 2, 2025
| pub type BankStatusCache = StatusCache<Result<()>>; | ||
| #[cfg_attr( | ||
| feature = "frozen-abi", | ||
| frozen_abi(digest = "4e7a7AAsQrM5Lp5bhREdVZ5QGZfyETbBthhWjYMYb6zS") |
There was a problem hiding this comment.
Can you include the diff of the abi files, please? I'd like to understand why this digest changed.
Member
Author
There was a problem hiding this comment.
--- /yihau/solana/abidiffm/bank__BankSlotDelta_frozen_abi__test_abi_digest_4e7a7AAsQrM5Lp5bhREdVZ5QGZfyETbBthhWjYMYb6zS 2025-05-03 09:43:17.580155571 +0000
+++ /yihau/solana/abidiffm/bank__BankSlotDelta_frozen_abi__test_abi_digest_5dfDCRGWPV7thfoZtLpTJAV8cC93vQUXgTm6BnrfeUsN 2025-05-03 09:45:25.018147913 +0000
@@ -3,7 +3,7 @@
primitive u64
element bool
primitive bool
- element alloc::sync::Arc<std::sync::mutex::Mutex<std::collections::hash::map::HashMap<solana_hash::Hash, (usize, alloc::vec::Vec<([u8; 20], core::result::Result<(), solana_transaction_error::TransactionError>)>)>>>
+ element alloc::sync::Arc<std::sync::poison::mutex::Mutex<std::collections::hash::map::HashMap<solana_hash::Hash, (usize, alloc::vec::Vec<([u8; 20], core::result::Result<(), solana_transaction_error::TransactionError>)>)>>>
map (entries = 1)
key solana_hash::Hash
struct Hash([u8; 32]) (newtype)| nightly_version="$RUST_NIGHTLY_VERSION" | ||
| else | ||
| nightly_version=2024-11-22 | ||
| nightly_version=2025-02-16 |
There was a problem hiding this comment.
For posterity, here's why we've chosen this nightly version: #5952 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
we're still using an old nightly version 💀
Summary of Changes
bump it
Close #5952 #5990