bump rust nightly to 2025-03-31#5952
Closed
yihau wants to merge 1 commit intoanza-xyz:masterfrom
Closed
Conversation
This was referenced Apr 24, 2025
Merged
Merged
Merged
|
Ha nice, I actually just noticed that our nightly is quite old too; glad you're already on in 🫡 |
brooksprumo
reviewed
May 1, 2025
| nightly_version="$RUST_NIGHTLY_VERSION" | ||
| else | ||
| nightly_version=2024-11-22 | ||
| nightly_version=2025-03-31 |
There was a problem hiding this comment.
I think we should bump to nightly-2025-02-16 instead. This is the last nightly of rust version 1.86.0. This would allow us to use the same stable and nightly versions.
Suggested change
| nightly_version=2025-03-31 | |
| nightly_version=2025-02-16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
we haven’t upgraded the nightly version in a while. it seems we don’t have a rule for which version to use, so I’ll just stick with this one:
Summary of Changes
bump it