Scheduler: slot-gated Retry#5913
Closed
apfitzge wants to merge 6 commits intoanza-xyz:masterfrom
Closed
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #5913 +/- ##
========================================
Coverage 82.9% 82.9%
========================================
Files 830 830
Lines 376347 376500 +153
========================================
+ Hits 312282 312469 +187
+ Misses 64065 64031 -34 🚀 New features to boost your workflow:
|
apfitzge
force-pushed
the
slot_gated_retry
branch
from
04f798b to
f8fbab4
Compare
bw-solana
reviewed
Apr 22, 2025
bw-solana
left a comment
bw-solana
left a comment
There was a problem hiding this comment.
Looks pretty good to me. A few nits
| pub num_unschedulable_conflicts: usize, | ||
| /// Number of transactions that were skipped due to thread capacity. | ||
| pub num_unschedulable_threads: usize, | ||
| /// Number of transactions that were skipped due too recently attempted. |
| }) | ||
| .unwrap(); | ||
|
|
||
| // Transaction should NOT be rescheduled |
There was a problem hiding this comment.
isn't this only true for the !immediate_retry case?
| self.sum_unschedulable_threads, | ||
| i64 | ||
| ), | ||
| ("num_skipped_retry", self.sum_skipped_retry, i64), |
There was a problem hiding this comment.
might be nice to align names. Something like num_unschedulable_skip_retry
Author
|
closed in favor of #6864 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes