scheduler: gate retry on slot#5268
Closed
apfitzge wants to merge 5 commits into
Closed
Conversation
tao-stones
reviewed
Mar 13, 2025
| |_| PreLockFilterAction::AttemptToSchedule // no pre-lock filter for now | ||
| |state| { | ||
| if state.last_tried_slot() == Some(bank_start.working_bank.slot()) { | ||
| PreLockFilterAction::SkipAndRetain |
There was a problem hiding this comment.
to clarify, what are the cases worker would send back tx for retry? Wondering if all retry cases are not suitable for current slot
Author
There was a problem hiding this comment.
- block limits exceeded
- poh recording failed (slot ended)
- account locks taken (shouldn't happen due to scheduling logic)
- ugh this does happen because of jito though...
- bank failed to become available in 50ms (in this case None is returned for the slot)
Author
|
Think we cannot do this because of the jito scheduler rugging - it'll fuck jito validators. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
Fixes #