add feature gate to collect and reward priority fee fully#583
Merged
tao-stones merged 3 commits intoanza-xyz:masterfrom Apr 17, 2024
Merged
add feature gate to collect and reward priority fee fully#583tao-stones merged 3 commits intoanza-xyz:masterfrom
tao-stones merged 3 commits intoanza-xyz:masterfrom
Conversation
apfitzge
requested changes
Apr 4, 2024
apfitzge
left a comment
apfitzge
left a comment
There was a problem hiding this comment.
we should update SchedulerController::calculate_priority_and_cost to appropriately consider the feature-gate.
Author
|
Good call! something like this: |
apfitzge
reviewed
Apr 5, 2024
tao-stones
force-pushed
the
simd0096-feature-gating
branch
2 times, most recently
from
389bad3 to
80c6427
Compare
tao-stones
force-pushed
the
simd0096-feature-gating
branch
from
34424a1 to
8445ca3
Compare
tao-stones
commented
Apr 16, 2024
| bank.feature_set | ||
| .is_active(&remove_rounding_in_fee_calculation::id()), | ||
| ); | ||
| let reward = bank.calculate_reward_for_transaction(transaction, fee_budget_limits); |
Author
There was a problem hiding this comment.
Simply sharing bank's reward calculation
There was a problem hiding this comment.
there will be some oddity here when the feature gets activated. txs received before feature-activation will still have old calculation (prio 50% burned) those after will not.
This will only be an effect around the epoch boundary.
apfitzge
approved these changes
Apr 17, 2024
michaelschem
pushed a commit
to michaelschem/agave
that referenced
this pull request
Apr 20, 2024
* add feature gate to collect and distribute priority fee fully * add feature gate logic to SchedulerController::calculate_priority_and_cost() * set feature gate status correctly for tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow up #178 and #566; Rewarding full priority fee will break consensus.
Summary of Changes
Fix Feature Gate Issue: solana-labs#34731