Skip to content

Marks collector_fees in snapshot as unused#10851

Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:snap/collector-fees
Feb 26, 2026
Merged

Marks collector_fees in snapshot as unused#10851
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:snap/collector-fees

Conversation

@brooksprumo
Copy link
Copy Markdown

Problem

The collector_fees field is unused by Bank, and thus the snapshot.

Summary of Changes

Remove it from the bank, and mark as unused in the snapshot.

@brooksprumo brooksprumo self-assigned this Feb 26, 2026
feature = "frozen-abi",
derive(AbiExample),
frozen_abi(digest = "FHeeuJgYyE1rqdLRycbJWC8PoTRZqYsRWZZCaP5A7DWb")
frozen_abi(digest = "EEwojKqUDSpYNeutW56K9bsJmsjCMZn8i4n3qgvJYRxf")
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frozen abi digest changed due to renaming the field.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.0%. Comparing base (8f1d12f) to head (e791e5d).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #10851     +/-   ##
=========================================
- Coverage    83.0%    83.0%   -0.1%     
=========================================
  Files         836      836             
  Lines      316338   316327     -11     
=========================================
- Hits       262665   262625     -40     
- Misses      53673    53702     +29     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brooksprumo brooksprumo marked this pull request as ready for review February 26, 2026 17:38
Comment thread core/src/banking_simulation.rs
Comment thread runtime/src/bank.rs
Comment on lines -843 to -844
/// Fees that have been collected
collector_fees: AtomicU64,
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are zero writers to this field in the repo. And since it is private, it would require a helper fn to write to it. There isn't a helper fn that exposes the field in a way that would allow writing.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This field stopped being used with the activation of this: #583"

@brooksprumo
Copy link
Copy Markdown
Author

@apfitzge - requesting your review since you reviewed #4773, which added the collector_fees log.

@steviez - requesting your review as someone that may know more about this field.

Copy link
Copy Markdown

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to drop dead stuff, snapshots looks correct as well in that we'll just populate a 0 to avoid breaking serde

@brooksprumo brooksprumo added this pull request to the merge queue Feb 26, 2026
Merged via the queue into anza-xyz:master with commit 4be1eb1 Feb 26, 2026
51 checks passed
@brooksprumo brooksprumo deleted the snap/collector-fees branch February 26, 2026 19:59
@brooksprumo
Copy link
Copy Markdown
Author

lol auto-merge merged before the windows CI checks completed?

@brooksprumo brooksprumo added the v4.0 Backport to v4.0 branch label Feb 27, 2026
@mergify
Copy link
Copy Markdown

mergify Bot commented Feb 27, 2026

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify Bot pushed a commit that referenced this pull request Feb 27, 2026
brooksprumo added a commit that referenced this pull request Mar 4, 2026
… (#10875)

Marks `collector_fees` in snapshot as unused (#10851)

(cherry picked from commit 4be1eb1)

Co-authored-by: Brooks <brooks@anza.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4.0 Backport to v4.0 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants