Marks collector_fees in snapshot as unused#10851
Conversation
9f178db to
d0f8c92
Compare
| feature = "frozen-abi", | ||
| derive(AbiExample), | ||
| frozen_abi(digest = "FHeeuJgYyE1rqdLRycbJWC8PoTRZqYsRWZZCaP5A7DWb") | ||
| frozen_abi(digest = "EEwojKqUDSpYNeutW56K9bsJmsjCMZn8i4n3qgvJYRxf") |
There was a problem hiding this comment.
Frozen abi digest changed due to renaming the field.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #10851 +/- ##
=========================================
- Coverage 83.0% 83.0% -0.1%
=========================================
Files 836 836
Lines 316338 316327 -11
=========================================
- Hits 262665 262625 -40
- Misses 53673 53702 +29 🚀 New features to boost your workflow:
|
| /// Fees that have been collected | ||
| collector_fees: AtomicU64, |
There was a problem hiding this comment.
There are zero writers to this field in the repo. And since it is private, it would require a helper fn to write to it. There isn't a helper fn that exposes the field in a way that would allow writing.
There was a problem hiding this comment.
"This field stopped being used with the activation of this: #583"
d0f8c92 to
e791e5d
Compare
steviez
left a comment
There was a problem hiding this comment.
Always good to drop dead stuff, snapshots looks correct as well in that we'll just populate a 0 to avoid breaking serde
|
lol auto-merge merged before the windows CI checks completed? |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
(cherry picked from commit 4be1eb1)
Problem
The
collector_feesfield is unused by Bank, and thus the snapshot.Summary of Changes
Remove it from the bank, and mark as unused in the snapshot.