Skip to content

Reverts incorrectly renamed comment#537

Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:collateral-damage
Apr 2, 2024
Merged

Reverts incorrectly renamed comment#537
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:collateral-damage

Conversation

@brooksprumo
Copy link
Copy Markdown

@brooksprumo brooksprumo commented Apr 2, 2024

Problem

In #447, one comment was incorrectly renamed, likely due to an eager find-and-replace. Here's the specific comment: https://github.com/anza-xyz/agave/pull/447/files#r1546761053

Summary of Changes

Revert the incorrect rename.

@brooksprumo brooksprumo self-assigned this Apr 2, 2024
@brooksprumo brooksprumo marked this pull request as ready for review April 2, 2024 12:32
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (798cb56) to head (2cf868f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #537     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         846      846             
  Lines      228904   228904             
=========================================
- Hits       187433   187425      -8     
- Misses      41471    41479      +8     

Copy link
Copy Markdown

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit a37b85c into anza-xyz:master Apr 2, 2024
@brooksprumo brooksprumo deleted the collateral-damage branch April 2, 2024 13:45
Copy link
Copy Markdown

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants