Rename append vec to accounts file for CurrentAncientAppendVec#447
Merged
jeffwashington merged 1 commit intoanza-xyz:masterfrom Apr 1, 2024
Merged
Rename append vec to accounts file for CurrentAncientAppendVec#447jeffwashington merged 1 commit intoanza-xyz:masterfrom
jeffwashington merged 1 commit intoanza-xyz:masterfrom
Conversation
yhchiang-sol
force-pushed
the
rn-accounts-file
branch
from
47d371f to
9e94def
Compare
yhchiang-sol
force-pushed
the
rn-accounts-file
branch
from
9e94def to
ac5809c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #447 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 841 841
Lines 228242 228242
=========================================
- Hits 186923 186910 -13
- Misses 41319 41332 +13 |
brooksprumo
approved these changes
Apr 1, 2024
| let original_path = tmp.path().join("123.456"); | ||
|
|
||
| // In remap_append_vec() we want to handle EEXIST (collisions), but we want to return all | ||
| // In remap_accounts_file() we want to handle EEXIST (collisions), but we want to return all |
There was a problem hiding this comment.
Looks like this rename may've been collateral damage to a find-and-replace.
We can fix this in a subsequent PR too.
This was referenced Apr 2, 2024
OliverNChalk
pushed a commit
to OliverNChalk/agave
that referenced
this pull request
Nov 11, 2025
…#447) Upstream have updated the way frozen ABI tests are defined, and in order to run the tests correctly, we need to specify this feature flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Many places in accounts-db code base use append-vec to
describe accounts-file as it was the only accounts-file format
we had. As we generalize the concept, we need to properly
rename those append-vec params / functions that are actually
refer to accounts-file.
Summary of Changes
Rename append vec to accounts file for CurrentAncientAppendVec