v2.2: Revert - Feature gate of disable_new_loader_v3_deployments (backport of #5300)#5315
Conversation
|
The Firedancer team maintains a line-for-line reimplementation of the |
c15f112 to
893a4be
Compare
|
making a release with this merged and the feature set not updated is going to create undetectable runtime incompatibilities with prior releases |
|
Only once we re-add the feature, and by the time we should have the feature set back in the Agave repository. |
893a4be to
dbba9f7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2.2 #5315 +/- ##
=======================================
Coverage 83.3% 83.4%
=======================================
Files 805 805
Lines 371543 371526 -17
=======================================
+ Hits 309816 309866 +50
+ Misses 61727 61660 -67 🚀 New features to boost your workflow:
|
Removes the feature gate of disable_new_loader_v3_deployments. (cherry picked from commit 4b9b0b7)
e95e9fd to
596d023
Compare
|
@pgarg66 mind SMEing this one one last time? |
Problem
See #5189. Because this feature is activated by default in the test validator, lots of dApp devs have trouble because the CLI program subcommand only throws an error message and does not automatically forward to the replacement program-v4 subcommand. Doing this forwarding turned out much more challenging than originally anticipated, so I decided to remove this feature gate until we have the changes in the CLI ready.
Summary of Changes
Partial revert of #4666. The feature set part will stay as it currently resides in the SDK repository and the feature gate will be added back in later anyway.
This is an automatic backport of pull request #5300 done by [Mergify](https://mergify.com).