Skip to content

v2.2: Revert - Feature gate of disable_new_loader_v3_deployments (backport of #5300)#5315

Merged
Lichtso merged 1 commit into
v2.2from
mergify/bp/v2.2/pr-5300
Mar 28, 2025
Merged

v2.2: Revert - Feature gate of disable_new_loader_v3_deployments (backport of #5300)#5315
Lichtso merged 1 commit into
v2.2from
mergify/bp/v2.2/pr-5300

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Mar 15, 2025

Problem

See #5189. Because this feature is activated by default in the test validator, lots of dApp devs have trouble because the CLI program subcommand only throws an error message and does not automatically forward to the replacement program-v4 subcommand. Doing this forwarding turned out much more challenging than originally anticipated, so I decided to remove this feature gate until we have the changes in the CLI ready.

Summary of Changes

Partial revert of #4666. The feature set part will stay as it currently resides in the SDK repository and the feature gate will be added back in later anyway.


This is an automatic backport of pull request #5300 done by [Mergify](https://mergify.com).

@mergify mergify Bot requested a review from a team as a code owner March 15, 2025 10:50
@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Mar 15, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso force-pushed the mergify/bp/v2.2/pr-5300 branch from c15f112 to 893a4be Compare March 17, 2025 15:30
pgarg66
pgarg66 previously approved these changes Mar 18, 2025
@t-nelson
Copy link
Copy Markdown

making a release with this merged and the feature set not updated is going to create undetectable runtime incompatibilities with prior releases

@Lichtso
Copy link
Copy Markdown

Lichtso commented Mar 18, 2025

Only once we re-add the feature, and by the time we should have the feature set back in the Agave repository.
Removing the logic of a feature gate in itself can not be rekeyed anyway.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.4%. Comparing base (39ae42d) to head (596d023).

Additional details and impacted files
@@           Coverage Diff           @@
##             v2.2    #5315   +/-   ##
=======================================
  Coverage    83.3%    83.4%           
=======================================
  Files         805      805           
  Lines      371543   371526   -17     
=======================================
+ Hits       309816   309866   +50     
+ Misses      61727    61660   -67     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pgarg66
pgarg66 previously approved these changes Mar 25, 2025
pgarg66
pgarg66 previously approved these changes Mar 28, 2025
Removes the feature gate of disable_new_loader_v3_deployments.

(cherry picked from commit 4b9b0b7)
@t-nelson
Copy link
Copy Markdown

@pgarg66 mind SMEing this one one last time?

@Lichtso Lichtso merged commit da38740 into v2.2 Mar 28, 2025
@Lichtso Lichtso deleted the mergify/bp/v2.2/pr-5300 branch March 28, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants