Skip to content

Revert - Feature gate of disable_new_loader_v3_deployments#5300

Merged
Lichtso merged 1 commit into
anza-xyz:masterfrom
Lichtso:revert/disable_new_loader_v3_deployments
Mar 15, 2025
Merged

Revert - Feature gate of disable_new_loader_v3_deployments#5300
Lichtso merged 1 commit into
anza-xyz:masterfrom
Lichtso:revert/disable_new_loader_v3_deployments

Conversation

@Lichtso
Copy link
Copy Markdown

@Lichtso Lichtso commented Mar 14, 2025

Problem

See #5189. Because this feature is activated by default in the test validator, lots of dApp devs have trouble because the CLI program subcommand only throws an error message and does not automatically forward to the replacement program-v4 subcommand. Doing this forwarding turned out much more challenging than originally anticipated, so I decided to remove this feature gate until we have the changes in the CLI ready.

Summary of Changes

Partial revert of #4666. The feature set part will stay as it currently resides in the SDK repository and the feature gate will be added back in later anyway.

@mergify
Copy link
Copy Markdown

mergify Bot commented Mar 14, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso force-pushed the revert/disable_new_loader_v3_deployments branch 2 times, most recently from fc19e9a to 965f014 Compare March 14, 2025 18:36
@Lichtso Lichtso force-pushed the revert/disable_new_loader_v3_deployments branch from 965f014 to 7605121 Compare March 14, 2025 19:18
@Lichtso Lichtso marked this pull request as ready for review March 14, 2025 19:47
@Lichtso Lichtso requested a review from a team as a code owner March 14, 2025 19:47
@Lichtso Lichtso merged commit 4b9b0b7 into anza-xyz:master Mar 15, 2025
1 check passed
@Lichtso Lichtso deleted the revert/disable_new_loader_v3_deployments branch March 15, 2025 10:49
@Lichtso Lichtso added the v2.2 label Mar 15, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented Mar 15, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify Bot pushed a commit that referenced this pull request Mar 15, 2025
Removes the feature gate of disable_new_loader_v3_deployments.

(cherry picked from commit 4b9b0b7)
Lichtso added a commit that referenced this pull request Mar 17, 2025
Removes the feature gate of disable_new_loader_v3_deployments.

(cherry picked from commit 4b9b0b7)
Lichtso added a commit that referenced this pull request Mar 25, 2025
Removes the feature gate of disable_new_loader_v3_deployments.

(cherry picked from commit 4b9b0b7)
Lichtso added a commit that referenced this pull request Mar 28, 2025
Removes the feature gate of disable_new_loader_v3_deployments.

(cherry picked from commit 4b9b0b7)
Lichtso added a commit that referenced this pull request Mar 28, 2025
…ackport of #5300) (#5315)

Revert - Feature gate of `disable_new_loader_v3_deployments` (#5300)

Removes the feature gate of disable_new_loader_v3_deployments.

(cherry picked from commit 4b9b0b7)

Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants