Move distribution methods; partitioned epoch-rewards reorg, 3 of 5#528
Merged
CriesofCarrots merged 3 commits intoanza-xyz:masterfrom Apr 3, 2024
Merged
Conversation
5 tasks
41a6653 to
5aac679
Compare
5aac679 to
ec75d55
Compare
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #528 +/- ##
========================================
Coverage 81.8% 81.8%
========================================
Files 843 847 +4
Lines 228586 228892 +306
========================================
+ Hits 187124 187407 +283
- Misses 41462 41485 +23 |
2 tasks
joncinque
approved these changes
Apr 2, 2024
OliverNChalk
pushed a commit
to OliverNChalk/agave
that referenced
this pull request
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Code for partitioned epoch rewards is peppered throughout bank.rs. It is very hard to trace the flows, and figure out which structs and methods are needed for calculation vs distribution, or for sysvar handling.
Summary of Changes
Moves distribution-related methods to submodule of
bank::partitioned_epoch_rewardsMoves unit tests
Includes some re-tightening of method scope in
sysvarsubmodule, since methods are now only used in thiedistributionsubmoduleBest reviewed by commit
This is PR 3 of 5 refactor this section of Bank code. The complete change is visible in a draft PR