Reorganize partitioned epoch rewards runtime code#510
Closed
CriesofCarrots wants to merge 20 commits intoanza-xyz:masterfrom
Closed
Reorganize partitioned epoch rewards runtime code#510CriesofCarrots wants to merge 20 commits intoanza-xyz:masterfrom
CriesofCarrots wants to merge 20 commits intoanza-xyz:masterfrom
Conversation
This was referenced Mar 29, 2024
d2fd097 to
43ed1a3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
43ed1a3 to
de5c43b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #510 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 843 848 +5
Lines 228586 228585 -1
=======================================
+ Hits 187124 187128 +4
+ Misses 41462 41457 -5 |
This was referenced Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Code for partitioned epoch rewards is peppered throughout bank.rs. It is very hard to trace the flows, and figure out which pieces are needed for calculation vs distribution.
Summary of Changes
Reorganize relevant code into the
bank::partitioned_epoch_rewardssubmodule.Reorganize unit tests into proper submodules
No functional changes, with the exception of removing a unit test that was testing a method I decided was superfluous.
Changes making things more
pubwere minimized. In a few cases,pubwas tightened.This is best reviewed by commit.
Smaller PRs (dare I say, partitions):