Skip to content

Reorganize partitioned epoch rewards runtime code#510

Closed
CriesofCarrots wants to merge 20 commits intoanza-xyz:masterfrom
CriesofCarrots:simd-118-refactor
Closed

Reorganize partitioned epoch rewards runtime code#510
CriesofCarrots wants to merge 20 commits intoanza-xyz:masterfrom
CriesofCarrots:simd-118-refactor

Conversation

@CriesofCarrots
Copy link
Copy Markdown

@CriesofCarrots CriesofCarrots commented Mar 29, 2024

Problem

Code for partitioned epoch rewards is peppered throughout bank.rs. It is very hard to trace the flows, and figure out which pieces are needed for calculation vs distribution.

Summary of Changes

Reorganize relevant code into the bank::partitioned_epoch_rewards submodule.
Reorganize unit tests into proper submodules
No functional changes, with the exception of removing a unit test that was testing a method I decided was superfluous.

Changes making things more pub were minimized. In a few cases, pub was tightened.

This is best reviewed by commit.

Smaller PRs (dare I say, partitions):

@mergify

This comment was marked as resolved.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 98.70130% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 81.8%. Comparing base (79e316e) to head (de5c43b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #510   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         843      848    +5     
  Lines      228586   228585    -1     
=======================================
+ Hits       187124   187128    +4     
+ Misses      41462    41457    -5     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants