Uses Into<PathBuf> for path in AppendVec::new()#433
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Mar 26, 2024
Merged
Uses Into<PathBuf> for path in AppendVec::new()#433brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo merged 1 commit intoanza-xyz:masterfrom
Conversation
22be92b to
29f0a3c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #433 +/- ##
=========================================
- Coverage 81.9% 81.8% -0.1%
=========================================
Files 840 841 +1
Lines 228107 228253 +146
=========================================
+ Hits 186851 186919 +68
- Misses 41256 41334 +78 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While reviewing #334, I made a wrong suggestion and noticed that the path parameter in
AppendVec::new()et al should beInto<PathBuf>instead of a raw Path orAsRef<Path>.Summary of Changes
Update AppendVec::new() et al to take the path parameter as
Into<PathBuf>, and update callers.