Uses Into<PathBuf> for path in AccountsFile::new_from_file()#434
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Mar 26, 2024
Merged
Uses Into<PathBuf> for path in AccountsFile::new_from_file()#434brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo merged 1 commit intoanza-xyz:masterfrom
Conversation
brooksprumo
force-pushed
the
paths/accounts-file
branch
from
844e929 to
d57899c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #434 +/- ##
=========================================
- Coverage 81.9% 81.8% -0.1%
=========================================
Files 840 841 +1
Lines 228107 228253 +146
=========================================
+ Hits 186851 186913 +62
- Misses 41256 41340 +84 |
brooksprumo
force-pushed
the
paths/accounts-file
branch
from
d57899c to
0e0ce12
Compare
yhchiang-sol
approved these changes
Mar 26, 2024
yhchiang-sol
left a comment
yhchiang-sol
left a comment
There was a problem hiding this comment.
LG! Thanks for the refactoring!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While reviewing #334, I made a wrong suggestion and noticed that the path parameter in
AppendVec::new()et al should beInto<PathBuf>instead of a raw Path orAsRef<Path>.This also extends to
AccountsFile::new_from_file().Summary of Changes
Update AccountsFile::new_from_file() to take the path parameter as
Into<PathBuf>.