Clarify TargetProgramBuiltin code docs#403
Merged
mergify[bot] merged 2 commits intoanza-xyz:masterfrom Mar 22, 2024
Merged
Conversation
buffalojoec
approved these changes
Mar 22, 2024
buffalojoec
left a comment
There was a problem hiding this comment.
Nice, much more clear. I'll extend to #332 as per your comments over there. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I thought of some clarifications to suggest on #331 after I already approved it and it was merged.
Summary of Changes
Update comments to be more specific about what struct contains and what ctor does
Update variable name to not overload the word config