Runtime: Core BPF Migration: Struct for loading and checking source BPF program accounts#332
Merged
buffalojoec merged 5 commits intoanza-xyz:masterfrom Mar 26, 2024
Merged
Conversation
6c917ad to
70c605b
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #332 +/- ##
=========================================
- Coverage 81.9% 81.8% -0.1%
=========================================
Files 840 841 +1
Lines 228098 228245 +147
=========================================
+ Hits 186818 186929 +111
- Misses 41280 41316 +36 🚀 New features to boost your workflow:
|
70c605b to
f82d301
Compare
Author
|
Note this can go in separate from #318. |
f82d301 to
baea4fe
Compare
CriesofCarrots
left a comment
There was a problem hiding this comment.
Despite the number of comments, this seems pretty close. Nothing major 😅
a830220 to
419262b
Compare
28e5e42 to
6aea930
Compare
CriesofCarrots
approved these changes
Mar 26, 2024
OliverNChalk
pushed a commit
to OliverNChalk/agave
that referenced
this pull request
Nov 11, 2025
Refactored to specify the vote protocol type explicitly. QUIC will require a more comprehensive rework and this code is UDP specific. Refactored-by: Illia Bobyr <illia.bobyr@anza.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is chunk 4/7 of the broken-up PR #79.
Problem
When the runtime desires to migrate a builtin program to Core BPF, it will do
so by replacing the builtin program's program account with that of a BPF
upgradeable program's program account, which will contain a pointer to its
corresponding program-data account.
Currently, there exists no reliable method in the bank or runtime more broadly
for loading a BPF upgradeable program's accounts and performing various
checks to ensure both program and program-data account are configured as
expected.
Being able to run these checks before fetching the program's accounts is
extremely important for ensuring a smooth migration to Core BPF.
Summary of Changes
Within the
builtinssubmodule, add a module specifically forcore_bpf_migration,and inside of it create a new structure for loading a source BPF upgradeable program's
program and program-data account and running checks.